JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Inside the major() setter method, set the student's major to a backing property "_major". If the student's level is Juni

Hi, this coding challenge got me stuck:

  Inside the major() setter method, set the student's major to a backing property "_major". If the student's level is Junior or Senior, the value of the backing property should be equal to the parameter passed to the setter method. If the student is only a Freshman or Sophomore, set the "_major" backing property equal to 'None'.

It probabaly it a simple solution :s

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

set level(level){
  this._level = level;
  }

get major() {
  return this._major;    
  }

set major(major){
    if(level === 'Senior' || level=== 'Junior'){
    this._major = major;
    } else {
      this._major = 'None';
    }
  }
}


var student = new Student(3.9, 60);

3 Answers

Steven Parker
Steven Parker
203,722 Points

You're very close, to access "level" from within the class code you need to prefix it with "self.".

Also, while it doesn't prevent you from passing the challenge, the instructions did not ask for a setter for "level" or a getter for "major". For best results in challenges, do only what the instructions ask for.

Hieu HO
Hieu HO
3,975 Points

not need set level(level){ this._level = level; }

daniel wilson
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
daniel wilson
Front End Web Development Techdegree Graduate 13,875 Points

delete both the "get major() {...}" and the "set level(level) {...}" and inside the if statement of "set major(major)" add the "this." prefix to both levels.