Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Making Decisions with Conditional Statements Document Your Code With Comments

Leroy Sharp
Leroy Sharp
2,711 Points
Posted by Leroy Sharp
Leroy Sharp
2,711 Points

Is the last conditional statement incorrect?

I have tried this program a few times but whenever I guess the number correctly on the second try it gives me the answer "Sorry. The number was x" even though I have answered with x.

Someone, please explain why this is happening.

Joseph Wasden
Joseph Wasden
20,407 Points

Can you post your code, so we can analyze it together?

Leroy Sharp
Leroy Sharp
2,711 Points
Leroy Sharp
Leroy Sharp
2,711 Points 
/* 
The Random Number Guessing Game
Generates a number between 1 and 6
and gives a player two attempts to 
guess the number.
*/
//assume the player didn't guess correctly
var correctGuess = false;

// generate random number from 1 to 6
var randomNumber = Math.floor(Math.random() * 6 ) + 1;

var guess = prompt('I am thinking of a number between 1 and 6. What is it?');

/* test to see if player is
1. correct
2. guessed too low
3. guessed too high
*/

if (parseInt(guess) === randomNumber ) {
  correctGuess = true;
} else if(parseInt(guess) < randomNumber) {
  var guessMore = prompt('Try again. The number I am thinking of is more than  ' + guess);
  if(parseInt(guess) === randomNumber) {
    correctGuess = true;
  }
} else if(parseInt(guess) > randomNumber) {
  var guessLess = prompt('Try again. The number I am thinking of is less than ' + guess);
  if(parseInt(guess) === randomNumber) {
    correctGuess = true;
  }
}

//test if the player is correct and output response
if ( correctGuess === true) {
    document.write('<p>You guessed the number!</p>');
} else {
    document.write('<p>Sorry. The number was ' + randomNumber + '.</p>');
}

1 Answer

Joseph Wasden
Joseph Wasden
20,407 Points
Joseph Wasden
Joseph Wasden
20,407 Points

Your if statements nested inside your else if statements should be referencing your guessMore and guessLess variables, respectively. Right now, they are still referring to the first guess stored in the guess variable, which won't change no matter how many second guesses a user provides.

Leroy Sharp
Leroy Sharp
2,711 Points
Leroy Sharp
Leroy Sharp
2,711 Points

Ah! That makes sense now. I didn't even realise that. I changed the nested if statements with the correct variables and now it works perfectly! Thanks a lot Joseph :)