Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

CSS

Aurelian Spodarec
Aurelian Spodarec
10,801 Points
Posted by Aurelian Spodarec
Aurelian Spodarec
10,801 Points

Is this CSS pretty clean?

What do you think about the CSS and HTML?

https://github.com/AurelianSpodarec/hcloverain/blob/gh-pages/assets/css/styles.css

Would you hire someone that write a code like this? Bare in mind i write 50% better every day lol since I'm just discovering CSS best/good practices.

If theres a tip so I can write a better CSS, please share. I want to move up without making the same mistakes over and over again, like I did in the past few years.

4 Answers

Kallil Belmonte
Kallil Belmonte
35,561 Points
Kallil Belmonte
Kallil Belmonte
35,561 Points

If I would make this site, I would organize the overall a little different, but not because it was wrong, just because of my own style to do things, people always will do things differently because of it.

Here are some interesting links for you ;)

SEMANTIC

http://diveintohtml5.info/semantics.html

http://www.w3schools.com/html/html5_semantic_elements.asp

http://codepen.io/mi-lee/post/an-overview-of-html5-semantics

CHEAT SHEETS

HTML and CSS Cheat Sheet

HTML5 The Mega Cheat Sheet

WEB DESIGN MANUAL

http://webfieldmanual.com/

RESPONSIVE WEB DESIGN MANUAL

http://bradfrost.github.io/this-is-responsive/index.html

WEB DEVELOPER MANUAL

http://webfieldmanual.com/code.html

WEB DEVELOPER CHECKLIST

http://webdevchecklist.com

Aurelian Spodarec
Aurelian Spodarec
10,801 Points
Aurelian Spodarec
Aurelian Spodarec
10,801 Points

That's great! A lot to read and learn! Thank you!

Last question, how close I am to be hired? In terms of writing the code? I started learning this when I was like.. 3years ago.. but the code wasn't the best. I got the logic and I know how CSS works, and I could do pretty much anything, it's just my code wasn't the cleanest.

Now I'm going throw TTH front-end track, and I'm making imediate changing to how i organize my code and the way i code. If you look on my portfolio , starting from Galaxy site, they are on github as well, then you see, galaxy site is my first site after i watched some CSS here on TTH, then Surfing was after i did more CSS tutorials here on TTH, and now the site you just checked, the Rain one, it was even more when I did most of the CSS here at TTH on the Front-end and not only, and each time i try to think of how i coudl build my site better, so I do it. Today i will probabbly start a new site and finish this later, meanwhile now im doing tutorials on JS, did alrady HTML and CSS today. Heres my portfolio - I didn't add the rain site yet.

Started on 27th, and i need about 38hours left to finsih the front-end track. I know the programming basics, jQuery a bit etc..

But my main point is, do you think I'd be ready for an interview as a front-end dev this month? Maybe in 20days? or ealier?

Aurelian Spodarec
Aurelian Spodarec
10,801 Points
Aurelian Spodarec
Aurelian Spodarec
10,801 Points

Hi again, im reading the links, and i was wondering, what do you think about this? :D

This here

Kallil Belmonte
Kallil Belmonte
35,561 Points
Kallil Belmonte
Kallil Belmonte
35,561 Points

Your code is pretty good, but I think that in your html you could include the nav, main and aside tags, always think in the semantic details.

Also I would like to recommend this workshop (I don't know if you already took it): CSS Best Practices

Aurelian Spodarec
Aurelian Spodarec
10,801 Points
Aurelian Spodarec
Aurelian Spodarec
10,801 Points

I'm going to make it better the next time I code it up! :)

I will code one today, and I will try my best again.

Nav? I was thinking about it, but it seemed it's an unnecessary tag, I mean, Guild doesn't use it sometimes. Unless it's good for the sake of it, I think I'll read up at semanitc docs again.

I did watch some of it, still need to finish it.

What parts of code do you think I should change? or CSS? Or maybe the way i organized things? maybe folder structure?

Do you have a perfect example of a site you did that's on github?

Kallil Belmonte
Kallil Belmonte
35,561 Points
Kallil Belmonte
Kallil Belmonte
35,561 Points

I think that in terms of writing code and develop websites, you are ready, now what you must do is to apply for these job opportunities, whether they be online or offline.

And never stop learning :)

Aurelian Spodarec
Aurelian Spodarec
10,801 Points
Aurelian Spodarec
Aurelian Spodarec
10,801 Points

Oh okay : p feel a bit more confident. I still think I need to write more websites with a perfect code, in terms of well documented, DRY, using skins or OOCSS so it's perfect lol I know that it comes with practice, and a bit of though before the coding, since I had to come up with random layouts , i didn't really know what to write, although OOCSS would solve the issues etc.. I mean, i hope you get me :D

Well, thank you for your help , review, links everything !! :)