JavaScript JavaScript Loops Working with 'for' Loops The Refactor Challenge – Duplicate Code

Is this solution ok?

So I called the Math.random function inside the randomRGB function instead of inside the call at the for loop. Is this ok or a bad practice? Thanks!

let html = '';
let main = document.querySelector('main');

let color = () => Math.floor(Math.random() * 256);

function randomRGB() {
  return `rgb( ${color()}, ${color()}, ${color()} )`;
}

for (let number = 1; number <= 10; number++) {
  html += `<div style="background-color: ${randomRGB()}">${number}</div>`;
}

main.innerHTML = html;
console.log(html);
Adam VanSlyke
Adam VanSlyke
15,979 Points

I personally like how it reads, but I'm not experienced enough to know if its a bad practice.

Ignacio Rocha
Ignacio Rocha
6,602 Points

is not a bad practice is just another kind of solution. But it's a better practice to create an arrow function declaration with 'const' instead of 'let' because you'll never reassigned a value to it.

kevin hudson
kevin hudson
Courses Plus Student 10,789 Points

This is very good and less code than mine. I also did the arrow functions.