Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Gavin van Hoeijen
Gavin van Hoeijen
2,938 Points
Posted by Gavin van Hoeijen
Gavin van Hoeijen
2,938 Points

Is this working properly? | https://teamtreehouse.com/library/javascript-and-the-dom-2/getting-a-handle-on-the-dom/pract

Heej all!

It could be me of course, but I'm doing the challenge and typed the following code in app.js that you can find with the HTML in this post.

When I checked the work it says that I only selected one link. However, I've copied the code and HTML in the workspace environment and checked the return on the variable. I saw not one link selected but the three links that where nested in <nav>.

So I'm lost.

thanks for reading, Have a great day!

js/app.js 
let navigationLinks = document.querySelectorAll("a.selected");
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul class="inner">
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html" class="selected">About</a></li>
          <li><a href="contact.html" class="selected">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

2 Answers

Michael Kobela
.a{fill-rule:evenodd;}techdegree seal-36
Michael Kobela
Full Stack JavaScript Techdegree Graduate 19,570 Points

I tried you code here and it works OK as well, but fails on the challenge. But the great thing about coding this that there is always another way of doing things. So I changed your selector to:

let navigationLinks = document.querySelectorAll("nav a");

and now it passes. It's selecting the nav element and all anchor children.

Gavin van Hoeijen
Gavin van Hoeijen
2,938 Points
Gavin van Hoeijen
Gavin van Hoeijen
2,938 Points

Thank you for your time!

I've finished the challenge now. Your solution is also a bit cleaner so I've made sure I understood it.

Have a great day Micheal!