Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Traversing the DOM Using previousElementSibling and insertBefore

Posted by baderbouta
baderbouta
7,804 Points

Isn't this kind of nesting highly discouraged in programming?

Hello,

I was wondering if the code that Guil wrote (see example below) isn't highly discouraged in programming?

listUl.addEventListener('click', (event) => {
  if (event.target.tagName == 'BUTTON') {

    if (event.target.className == 'remove') {
      let li = event.target.parentNode;
      let ul = li.parentNode;
      ul.removeChild(li);
    }

    if (event.target.className == 'up') {
      let li = event.target.parentNode;
      let prevLi = li.previousElementSibling;
      let ul = li.parentNode;

      if (prevLi) {
        ul.insertBefore(li, prevLi);
      } 

    }

  }
});

We got an if, nested in an if, nested in an if... thanks for the input :)

1 Answer

Sam Gord
Sam Gord
14,084 Points
Sam Gord
Sam Gord
14,084 Points

practically what this code is doing here can be written in different and probably easier ways . based on how the markup is looking and what our expectations might be . but according to the title of this course which is " Traversing the DOM / Using previousElementSibling and insertBefore " i think it's a very good example of what it tries to deliver . once you understand the concept u can get over the problem and write your own code however u think it's best .

baderbouta
baderbouta
7,804 Points

It's what I've figured, thanks Sam.

Sam Gord
Sam Gord
14,084 Points
Sam Gord
Sam Gord
14,084 Points

sure, happy coding ;)