It's always 0 when I use "||" instead of "=" .

Question

here's my code:
/*
  5. Rank player based on number of correct answers
   - 5 correct = Gold
   - 3-4 correct = Silver
   - 1-2 correct = Bronze
   - 0 correct = No crown
*/
 if (correct === 1 || correct === 2){
  rank = "Bronze" 
}else if(correct === 3 || correct === 4){
  rank = "Silver"  
}else if (correct === 5){
  rank = "Gold"
}else {
  rank = "None :("
}
Could someone tell me why?

Tim Danner · Answer

Your code runs fine on my end. Have you counted the correct answers?
However, the codes could also be refactored with a switch statement when there's too many if statements involved:
```js
let rank;
// play with this variable to see different results
let correct = 5;
switch (correct) {
    case 5:
        rank = "Gold";
        break;
    case 4:
    case 3:
        rank = "Silver";
        break;
    case 2:
    case 1:
        rank = "Bronze";
        break;
    default:
        rank = "No crown";
        break;
}
```

Welcome to the Treehouse Community

Looking to learn something new?

Xun Huang

Xun Huang

It's always 0 when I use "||" instead of ">=" .

1 Answer

Tim Danner

Tim Danner

Xun Huang

Xun Huang