Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Java Local Development Environments Advanced Tooling Finishing TreeStory

natalie murphy
natalie murphy
2,595 Points

It's hard to debug without seeing the test that is failing.

line 79 there is a null pointer exception. I added || choice == null but that did not seem to fix the problem.

com/teamtreehouse/Main.java
package com.teamtreehouse;

public class Main {

   public static void main(String[] args) {
      Prompter prompter = new Prompter();
      String story = "Thanks __name__ for helping me out.  You are really a __adjective__ __noun__ and I owe you a __noun__.";
      Template tmpl = new Template(story);
      prompter.run(tmpl);
   }
}
com/teamtreehouse/Prompter.java
package com.teamtreehouse;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;


public class Prompter {
   private BufferedReader mReader;
   private Set<String> mCensoredWords;

   public Prompter() {
      mReader = new BufferedReader(new InputStreamReader(System.in));
      loadCensoredWords();
   }

   private void loadCensoredWords() {
      mCensoredWords = new HashSet<String>();
      Path file = Paths.get("resources", "censored_words.txt");
      List<String> words = null;
      try {
         words = Files.readAllLines(file);
      } catch (IOException e) {
         System.out.println("Couldn't load censored words");
         e.printStackTrace();
      }
      mCensoredWords.addAll(words);
   }

   public void run(Template tmpl) {
      List<String> results = null;
      try {
         results = promptForWords(tmpl);
         System.out.printf("Your TreeStory:%n%n%s", tmpl.render(results));
      } catch (IOException e) {
         System.out.println("There was a problem prompting for words");
         e.printStackTrace();
         System.exit(0);
      }
   }

   /**
    * Prompts user for each of the blanks
    *
    * @param tmpl The compiled template
    * @return
    * @throws IOException
    */
   public List<String> promptForWords(Template tmpl) throws IOException {
      List<String> words = new ArrayList<>();
      for (String phrase : tmpl.getPlaceHolders()) {
         String word = promptForWord(phrase);
         words.add(word);
      }
      return words;
   }

   /**
    * Prompts the user for the answer to the fill in the blank.  Value is guaranteed to be not in the censored words list.
    *
    * @param phrase The word that the user should be prompted.  eg: adjective, proper noun, name
    * @return What the user responded
    */
   public String promptForWord(String phrase) throws IOException {
      System.out.printf("Can you give me a %s? %n", phrase);
      String choice = mReader.readLine();
      if (mCensoredWords.contains(choice)) {
         System.out.printf("That's a censored word, try again.%n");
         choice = promptForWord(phrase);
      }
      else if (choice.isEmpty()) {
         System.out.printf("try again.%n");
         choice = promptForWord(phrase);
      }
      return choice;
   }
}
pseudo-tests.md
#  This is essentially what I am testing 
1.  The user is prompted for a new string template (the one with the double underscores in it).

  a. The prompter class has a new method that prompts for the story template, and that method is called.

2.  The user is then prompted for each word that has been double underscored.

   a. The answer is checked to see if it is contained in the censored words.
      User is continually prompted until they enter a valid word

3.  The user is presented with the completed story

1 Answer

Have you tried checking if choice is null before trying to use it in if (mCensoredWords.contains(choice)) {?

If you use choice.isEmpty() || choice == null, Java will try to find the result of the left side before trying to find the result of the right side. If choice is in fact null, then the left side gives you a null pointer exception and the right side is not computed. If instead you use choice == null || choice.isEmpty() when the value of choice is null, Java will determine that choice == null is true and ignore the right side.