Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

It's working fine in another text editor. But it's not working here.

What is the problem with this code? What is missing?

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    set major(major) {
      if(major === 'Junior' || major === 'Senior') this._major = major;
      else this._major = 'None';
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
}

var student = new Student(3.9, 60);

2 Answers

Eric M
Eric M
11,515 Points

Hi Shikar,

Consider what your if statement is testing. What you've written checks if you've been passed "Junior" or "Senior" and sets that as the major, otherwise it sets the major to none.

Junior and Senior are levels, major will be something else. Instead you need to test the level using the getter function that's already present in the code for this challenge.

if(this.level === 'Junior' || this.level === 'Senior')
{
        this._major = major;
}
else
{
        this._major = 'None';
}

Cheers,

Eric

Thanks a lot for the explanation Eric. It's worked this time.