Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Shikhar Prateek
Shikhar Prateek
13,908 Points

It's working fine in another text editor. But it's not working here.

What is the problem with this code? What is missing?

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    set major(major) {
      if(major === 'Junior' || major === 'Senior') this._major = major;
      else this._major = 'None';
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
}

var student = new Student(3.9, 60);

2 Answers

Eric M
Eric M
11,545 Points
Eric M
Eric M
11,545 Points

Hi Shikar,

Consider what your if statement is testing. What you've written checks if you've been passed "Junior" or "Senior" and sets that as the major, otherwise it sets the major to none.

Junior and Senior are levels, major will be something else. Instead you need to test the level using the getter function that's already present in the code for this challenge.

if(this.level === 'Junior' || this.level === 'Senior')
{
        this._major = major;
}
else
{
        this._major = 'None';
}

Cheers,

Eric

Shikhar Prateek
Shikhar Prateek
13,908 Points
Shikhar Prateek
Shikhar Prateek
13,908 Points

Thanks a lot for the explanation Eric. It's worked this time.