Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript

Jose Rosado
Jose Rosado
3,090 Points

Javascript Code Review request

I've been learning Js for 4 weeks. I believe programming it's a great skill to have. Therefore, even though I'm a graphic designer, I believe this will adds so much value to professional career.

I would like to hear from some of you about my first attempt to program something without following a tutorial. Remember I'm a newbie: https://github.com/jrosadocruz/learn-js

2 Answers

As Samuel said, this does indeed look quite professional. Nice job.

This is more of a note than a crit but, I have in the past had issues with removing and adding lots of DOM elements. Sometimes, they are removed from view but simply remain in memory. The "Garbage Collector" is supposed to take care of this in the background, but it doesn't always work. In this situation, it would not really affect performance until thousands of pages of questions had been swapped out. However, it's generally best to change the element's content whenever possible, rather than invoke a new one.

Like I said, just a note for future reference. Great job on this!