Javascript does not work as expected

Question

Hi, I try to run his code

var randomNbre = randomNumber (1); var guess; var guessCounter = 0; var chances = 10 var correct = false;

function randomNumber (upper) { return Math.floor(Math.random() * upper) + 1; }

while (guessCounter < 10) { guess = prompt ("I'm thinking to a number between 1 and 10 which one is it ?"); if (parseInt (guess) === randomNumber) { correct = true; break; } alert("You still " + chances + " Chance. Correct number is " + randomNbre); chances--; guessCounter++; }

if (correct) { document.write("Yep"); } else { document.write("you should refresh the page"); }

console.log(correct);

but it's not work because even if I find the right number, my variable correct is still false. Can you help me please ?

Thank you.

Answer 1 · 2016-08-02T00:00:35Z

August 2, 2016 12:00am

You are not comparing your stored random number to the input.

When you pick the random number, you store it in a variable named randomNbre, but when you check the input, you compare it to randomNumber (which is the name of the function).

if (parseInt (guess) === randomNumber)  // <-- should be "randomNbre"

Now that you can fix the issue, I'm guessing you will also want to change the range on the first line (back to 10?).

Answer 2 · 2016-08-01T23:59:41Z

August 1, 2016 11:59pm

var randomNbre = randomNumber(10); 

var guess; 
var guessCounter = 0; 
var chances = 10; 
var correct = false;

function randomNumber (upper) { 
          return Math.floor(Math.random() * upper) + 1; 
}

while (guessCounter < 10) { 
guess = prompt ("I'm thinking to a number between 1 and 10 which one is it ?"); 
if (parseInt(guess) === randomNbre) { 
      correct = true; 
      break; 
} 

chances--; 
alert("You still have " + chances + " chances to guess."); 
guessCounter++;

 }

if (correct) { 
document.write("Yep"); 
} else { 
document.write("you should refresh the page"); }

console.log(correct);

I just fixed some of the spacing issues and missed quotation markers. The biggest issue was that your if statement was comparing parseInt(guess) to randomNumber instead of the variable you created to hold the random number.

Also, I took out the statement in the alert about sharing the random number while they are guessing.

Answer 3 · 2016-08-02T00:07:33Z

August 2, 2016 12:07am

Thank you guys. Noob mistake XD.

Welcome to the Treehouse Community

Looking to learn something new?

Kuzo Geko

Kuzo Geko

Javascript does not work as expected

3 Answers

Steven Parker

Steven Parker

You are not comparing your stored random number to the input.

Erik Nuber

Erik Nuber

Kuzo Geko

Kuzo Geko