Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Jquery

$external = $(this); $external.attr(target);

whats wrong in this? can you pls tell me how my code will be?

js/app.js
$external = $(this);
$external.attr(target)
index.html
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

1 Answer

Steven Parker
Steven Parker
229,744 Points

SPOILER ALERT:exclamation: (:see_no_evil:)

OK, with that out of the way, let's dissect the challenge. It's asking you to add to all links with the class "external", the target attribute with the value of "_blank". So what's a link? It's an a tag, right? So a JQuery selector for links having the class "external" would be $("a.external").

You knew that .attr() is the JQuery function to add an attribute, but it takes two arguments, the attribute name and value. We know the attribute name needs to be "target", and we want the value to be "_blank".

So a one-liner in JQuery that would set this attribute on all matching links would be:

js/app.js
$("a.external").attr("target", "_blank");

Thank You Very Much Steven