jQuery variable issue in a shared function

Question

I have a function called 'stringToFloat' which is not quite working for me.

All the code is shared except 1 line that I need to find a clean way to alternate when necessary.

function valueChange() {
    // repeated code starts
    var float= /^\s*(\+|-)?((\d+(\.\d+)?)|(\.\d+))\s*$/;
    var string = $("#project-change").val();
    var num = parseFloat(string);
    var textPercent = num.toFixed(0)
    // repeated code ends
}

function stageCheck() {
    $('.project-completion').each(function() {
        // repeated code starts
        var float= /^\s*(\+|-)?((\d+(\.\d+)?)|(\.\d+))\s*$/;
        var string = $(this).find('h3').text();
        var num = parseFloat(string);
        var textPercent = num.toFixed(0)
        // repeated code ends

As you can see, it's the *var string = * line that I need to alternate between.

Anyone got any clean coding ideas for this? I don't really want to use an if statement with a boolean variable that is not needed but I think that this may be the only way.

I imagine it will need to look something like this. (Code is not working like this but I guess you get the gist :) )

function stringToFloat() {
    var float= /^\s*(\+|-)?((\d+(\.\d+)?)|(\.\d+))\s*$/;

    // pseudo code starts
    if (project-change is what you need) {
        var string = $("#project-change").val();
    }
    if (you want 'this' then run this) {
        var string = $(this).find('h3').text();
    }
    //pseudo code ends

    var num = parseFloat(string);
    var textPercent = num.toFixed(0)

}

Any ideas? My brain is fried :(

Answer 1 · 2015-03-08T05:03:32Z

March 8, 2015 5:03am

Hi Liam,

If all code is shared except that line, why not create a function with the common code, pass it the string and return the result?

Something like this:

function valueChange() {

    var string = $("#project-change").val();
     var result = myFunction(string);
}

function stageCheck() {
    $('.project-completion').each(function() {

        var string = $(this).find('h3').text();
        var result = myFunction(string);

}

function myFunction(string){
        var float= /^\s*(\+|-)?((\d+(\.\d+)?)|(\.\d+))\s*$/;
        var num = parseFloat(string);
        return num.toFixed(0); 
}

Welcome to the Treehouse Community

Looking to learn something new?

Liam Maclachlan

Liam Maclachlan

jQuery variable issue in a shared function

1 Answer

Hugo Paz

Hugo Paz

Liam Maclachlan

Liam Maclachlan