JS Basic Challenge Task 2

Question

Why my code does not pass? It seems that my Task 1 does not pass after I put this code on my JS file. FYI, I put the script tag in the body, right after div

index.html

<!DOCTYPE html>
<html lang="en">
  <head>
    <title> JavaScript Foundations: Variables</title>
    <style>
      html {
        background: #FAFAFA;
        font-family: sans-serif;
      }
    </style>

  </head>
  <body>

    <h1 id="title">JavaScript Foundations</h1>
    <h2>Variables: Basics</h2>

    <div id="container">
      This is a div with the id of "container"
    </div>
    <script src="myscript.js"></script>
  </body>
</html>

myscript.js

/* JavaScript Foundations: Variables */

var bgColor = "";
var textColor = "";

var container = document.getElementById('title');
container.style.background = bgColor;
container.style.color = textColor;
bgColor = Blue;
textColor= #FF9933;

Answer 1 · 2015-01-04T04:52:32Z

January 4, 2015 4:52am

Hi Max,

The following code is what's causing the issue.

bgColor = Blue;
textColor= #FF9933;

This is invalid JavaScript as all strings (which blue and #FF9933 are) need to be wrapped within single or double quotes to prevent unexpected errors such as the one you're getting with the code challenge. The other issue is you have these values declared in the wrong spot as they're supposed to have been placed in the predefined variables as seen below.

var bgColor = "blue";
var textColor = "#FF9933";

So by the time you get up to task 3 your code should be the following.

var bgColor = "blue";
var textColor = "#FF9933";

var container = document.getElementById('title');
container.style.background = bgColor;
container.style.color = textColor;

Happy coding!

Welcome to the Treehouse Community

Looking to learn something new?

Max Kusnadi

Max Kusnadi

JS Basic Challenge Task 2

1 Answer

Chris Shaw

Chris Shaw