Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Android

pdiaz
pdiaz
16,073 Points

Json exception no value for time, no value for humidity

I am currently on the weather app course and keep the app keeps throwing this exception even though the JSON object is still producing the data. Here is the code

private static final String TAG = MainActivity.class.getSimpleName();

private CurrentWeather mCurrentWeather;
@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    String apiKey = "802e9e7ad9d4a3fcfba47cef8a20b9d0";
    double latitude =  37.8267;
    double longitude = -122.423;
    String forecastUrl = "https://api.forecast.io/forecast/" + apiKey +
            "/" + latitude + "," + longitude;

    if(isNetworkAvailable()) {
        OkHttpClient client = new OkHttpClient();
        Request request = new Request.Builder()
                .url(forecastUrl)
                .build();

        Call call = client.newCall(request);
        call.enqueue(new Callback() {
            @Override
            public void onFailure(Call call, IOException e) {

            }

            @Override
            public void onResponse(Call call, Response response) throws IOException {

                try {
                    String jsonData =  response.body().string();
                    Log.v(TAG, jsonData);
                    if (response.isSuccessful()) {
                        mCurrentWeather = getCurrentDetails(jsonData);
                    } else {

                    }

                } catch (IOException | JSONException e) {
                    Log.e(TAG, "Execption found: " + e);
                }
            }

        });
    }
    else {
        Toast.makeText(this, R.string.network_unavailable, Toast.LENGTH_SHORT).show();
    }
    Log.d(TAG, "Main ui code is running");
}

private CurrentWeather getCurrentDetails(String jsonData) throws JSONException{
        JSONObject forecast = new JSONObject(jsonData);
        String timezone = forecast.getString("timezone");
         Log.i(TAG, "From JSON: " + timezone);

         JSONObject currently = new JSONObject(jsonData);
    CurrentWeather currentWeather = new CurrentWeather();
    currentWeather.setHumidity(currently.getDouble("humidity"));
    currentWeather.setTime(currently.getLong("time"));
    currentWeather.setIcon(currently.getString("icon"));
    currentWeather.setPrecipChance(currently.getDouble("precipProbability"));
    currentWeather.setSummary(currently.getString("summary"));
    currentWeather.setTemperature(currently.getDouble("temperature"));

currentWeather.setTimeZone(timezone);

    Log.d(TAG, currentWeather.getFormattedTime());
        return currentWeather;
}

private boolean isNetworkAvailable() {
    ConnectivityManager manager = (ConnectivityManager)
            getSystemService(Context.CONNECTIVITY_SERVICE);
    NetworkInfo networkInfo = manager.getActiveNetworkInfo();
    boolean isAvailable = false;
    if(networkInfo != null && networkInfo.isConnected()){
        isAvailable = true;
    }
    return isAvailable;
}

private void alertUserAboutError() {
    if (!MainActivity.this.isFinishing()) {
        AlertDialogFragment dialog = new AlertDialogFragment();
        dialog.show(getFragmentManager(), "error_dialog");
    }
}

You should print out the response.body().string() to see if you are actually getting data.

I think the line JSONObject currently = new JSONObject(jsonData); Should be JSONObject currently = forecast.getJsonObject('currently');

1 Answer

I think the line JSONObject currently = new JSONObject(jsonData); Should be JSONObject currently = forecast.getJsonObject('currently');

pdiaz
pdiaz
16,073 Points

Thanks! It finally works.