Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Posted by Mathew Yangang
Mathew Yangang
4,433 Points

just curious, what's wrong with this code?

Got a couple of errors, not sure what i'm doing wrong

script.js 
a = 1;
b = 2;
function max(1,2){
if (b>a)
  return (2);
}

2 Answers

Jon Tang
Jon Tang
6,518 Points
Jon Tang
Jon Tang
6,518 Points

Your functions have to have parameters. Like a and b instead of 1 and 2.

function max (a , b) {
 }

then you state what that function does.

function max (a , b) {
  //Your code here
};

which is...

function max (a , b) {
  if (b > a ) {
    return(2);
  };
};

then use console.log to return your results

function max (a , b) {
  if (b > a ) {
    return(2);
  };
};
console.log(max(1, 2));

this should return 2 in the web console

Mathew Yangang
Mathew Yangang
4,433 Points
Mathew Yangang
Mathew Yangang
4,433 Points

Thanks Jon.

Mathew Yangang
Mathew Yangang
4,433 Points

I did that, but the function max is not working