Letter game

Question

i'm not sure what's wrong her
when the answer given is 'banana' or 'apple'
it doesn't let me win and quit the game
```python import random
make a list of words
words = [
    'apple',
    'banana',
    'orange',
    'strawberry',
    'lime',
    'grapefruit',
    'lemon',
    'kumpquat',
    'blueberry',
    'melon',
]
while True:
    start = input("Press enter or return, or press Q to quit ")
    if start.lower() == 'q':
        break
# pick a random word
secret_word = random.choice(words)
good_guesses = []
bad_guesses = []

while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):
    # draw spaces, guesses letter, and strikes 
    for letter in secret_word:
        if letter in good_guesses:
            print(letter, end='')
        else:
            print ('_', end='')

print ('')
    print ("Strikes: {}/7".format(len(bad_guesses)))
    print ('')

# take guess
    guess = input("Take a guess:").lower()

if len(guess) != 1:
        print ("You should answer one letter at a time!")
        continue 
    elif guess in bad_guesses or guess in good_guesses:
        print ("You already use that letter")
        continue
    elif not guess.isalpha():
        print ("You can only type letters!")
        continue

if guess in secret_word:
        good_guesses.append(guess)
        if len(good_guesses) == len(list(secret_word)):
            print ("You win! The word was {}!".format(secret_word))
            break
    else:
        bad_guesses.append(guess)
else:
    print("Sorry you lose... the word was {}".format(secret_word))
```

Steven Parker · Answer

:point_right: You need a different strategy for finding a win.
In the code above, you check the number of correct guesses against the length of the word to determine a win.  That will work for words where every letter is different, but for words with repeated letters like 'banana' or 'apple' a win will occur while the number of good guesses is less than the size of the word.
You need a different checking strategy.  What if you compared the size of good_guesses against only the number of unique letters, or checked if each letter of the word was in good_guesses?

Welcome to the Treehouse Community

Looking to learn something new?

Gilang Ilhami

Gilang Ilhami

Letter game

make a list of words

1 Answer

Steven Parker

Steven Parker

You need a different strategy for finding a win.