Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Letter Game App Letter Game Refinement

Posted by Rakshith Nayak
Rakshith Nayak
1,893 Points

Letter Game Refinement

There's something wrong with my code which i directly copied from the Letter Game Refinement video but it isn't giving me the right output. Could someone please help me fix this. Thank you

import os import random import sys

words = [ 'apple', 'banana', 'orange', 'coconut', 'strawberry', 'lime', 'grapefruit', 'lemon', 'kumquat', 'blueberry', 'melon' ]

def clear(): if os.name == 'nt': os.system('cls') else: os.system('clear')

def draw(bad_guesses, good_guesses, secret_word): clear()

print('Strikes: {}/7'.format(len(bad_guesses)))
print('')

for letter in bad_guesses:
    print(letter, end=' ')
print('\n\n')

for letter in secret_word:
    if letter in good_guesses:
        print(letter, end='')
    else:
        print('_', end='')

print('')

def get_guess(bad_guesses, good_guesses): while True: guess = input("Guess a letter: ").lower()

    if len(guess) != 1:
        print("You can only guess a single letter!")
    elif guess in bad_guesses or guess in good_guesses:
        print("You've already guessed that letter!")
    elif not guess.isalpha():
        print("You can only guess letters!")  
    else:
        return guess

def play(done): clear() secret_word = random.choice(words) bad_guesses = [] good_guesses = []

while True:
    draw(bad_guesses, good_guesses, secret_word)
    guess = get_guess(bad_guesses, good_guesses)

    if guess in secret_word:
        good_guesses.append(guess)
        found = True
        for letter in secret word:
            if letter not in good guesses:
                found = False   
        if found:        
            print("You win!")
            print("The secret word was {}".format(secret_word))
            done = True
    else:
        bad_guesses.append(guess)
        if len(bad_guesses) == 7:
            draw(bad_guesses, good_guesses, secret_word)
            print("You lost!")
            print("The secret word was {}".format(secret_word))
            done = True

    if done:
        play_again = input("Play again? Y/n ").lower()
        if play_again != 'n':
            return play(done=False)
        else:
            sys.exit()

def welcome(): start = input("Press enter/return to start or Q to quit ").lower() if start == 'q': print("Bye!") sys.exit() else: return True

print('Welcome to Letter Guess!')

done = False

while True: clear() welcome() play(done)

2 Answers

Suleiman Abdurozikov
Suleiman Abdurozikov
2,943 Points
Suleiman Abdurozikov
Suleiman Abdurozikov
2,943 Points

Probably you may have Indentation problem , That is python even if all your script is all right indentation may cause some trouble and mind blowing, however I would suggest to check one more time this issue

jp28
jp28
3,413 Points
jp28
jp28
3,413 Points

Try this code i made:

import sys import os import random

words = ['orlando', 'miami', 'santiago', 'lima', 'madrid', 'liverpool', 'new york', 'chicago' ]

def clear(): if os.name == 'nt': os.system('cls') else: os.system('clear')

def draw(bad_guesses, good_guesses, secret_word): clear()

print('Strikes: {}/7'.format(len(bad_guesses)))
print('')

for letter in bad_guesses:
    print(letter, end=' ')
print('\n\n')


for letter in secret_word:
        if letter in good_guesses:
            print(letter, end='')
        else:
            print('_', end='')


print('')

def get_guess(bad_guesses, good_guesses): while True: guess = input("Gues a letter: ").lower()

    if len(guess) != 1:
        print("You can only guess one letter!")
    elif guess in bad_guesses or guess in good_guesses:
        print("You've already guess that letter!")
    elif not guess.isalpha():
        print("You can only guess letters!")
    else:
        return guess

def play(done): clear() secret_word = random.choice(words) bad_guesses = [] good_guesses = []

while True:
    draw(bad_guesses, good_guesses, secret_word)
    guess = get_guess(bad_guesses, good_guesses)

    if guess in secret_word:
        good_guesses.append(guess)
        found = True
        for letter in secret_word:
            # Fixed: removed list() wrapper from letter
            if letter not in good_guesses:
                found = False

        if found:
            print("You Win!")
            print("The secret word was {}".format(secret_word))

            done = True
    else:
        bad_guesses.append(guess)
        if len(bad_guesses) == 7:
            draw(bad_guesses, good_guesses, secret_word)
            print("You lost!")
            print("The secret word was {}".format(secret_word))
            done = True
    # Fixed: unindent check for 'done' so check is made after
    # good (win) / bad (loss) guess determination.
    if done:
        play_again = input("Play again? Y/n ".lower())
        if play_again != 'n':
            return play(done=False)
        else:
            print("Bye")
            sys.exit()

def welcome(): start = input("Press enter/return to start or Q to quit").lower() if start == 'q': print("Bye!") sys.exit() else: return False

print("Welcome to the Letter Game!")

done = False

while True: clear() welcome() play(done)