Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Letter Game App Letter Game Introduction

letter_game.py

Hello, I wrote the same code as in the lesson but the program does not end when i guess the right word as it should be. I don't know why.

import random 

words = ['apple', 'banana', 'orange', 'coconut', 'lime', 'lemon', 'blueberry']


while True:
    start = input("press inter/return to start, or enter Q to quit")
    if start.lower() == 'q':
        break



    secret_word= random.choice(words)
    bad_guesses = []
    good_guesses= []

    while len(bad_guesses) <7 and len(good_guesses)!= len(list(secret_word)):
        for letter in secret_word:
            if letter in good_guesses:
                print(letter, end='')
            else:
                print('_', end='')


        print('')
        print("strikes: {}/7".format(len(bad_guesses)))
        print('')


        guess = input ("Guess a letter:").lower()
        if len(guess)!=1:
            print("you can only guess a single letter!")
            continue
        elif guess in bad_guesses or guess in good_guesses:
            print("you have already guess that letter")
            continue
        elif not guess.isalpha():
            print("you can only guess letters!")
            continue

        if guess in secret_word:
            good_guesses.append(guess)
            if len(good_guesses)== len(list(secret_word)):
                print("You win! The word was {}".format(secret_word))
                break
        else:
            bad_guesses.append(guess)
    else:
        print("you did not guess it my secret word was {}".format(secret_word))

2 Answers

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,441 Points

The issue is the length of the secret word doesn't consider if the secret word has repeated letters. If there are repeats, the length of guess could never match the secret word length. In the video teacher's notes, Kenneth admits this issue exists and will be addressed in the next video.

Hint: if you want to fix it yourself, a set is a quick way to get the unique characters.

Post back if you need more help. Good luck!!

Check out my version of the game. I wrote it from scratch before watching video: https://repl.it/Kxk9/102