Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community!

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Gary Gibson
Gary Gibson
5,011 Points
Posted by Gary Gibson
Gary Gibson
5,011 Points

List Only Showing Last Item Entered In All Spots Created

Shopping List Take 3.

Only the last item I entered appears on the final lists.

shopping_list = []

def show_help():
    print("\nSeparate each item with a comma.")
    print("DONE to quit, SHOW to see current list, HELP to get this message.")

def show_list():
    count = 1
    for itme in shopping_list:
        print("{}: {}".format(count, item))
        count += 1

print("Give me a list of things you want to get or do.")
show_help()

while True:
    new_stuff = input("> ")

    if new_stuff == 'DONE':
        print("\nHere's your list:")
        show_list()
        break

    elif new_stuff == 'HELP':
        show_help()
        continue

    elif new_stuff == 'SHOW':
        show_list()
        continue

    else:
        new_list = new_stuff.split(", ")
        index = input("Add this at a certain spot? Press enter for the end of the list, "
                      "or give me a number. Currently {} items in the list.".format(len(shopping_list)))

        if index:
            spot = int(index) - 1
            for item in new_list:
                shopping_list.insert(spot, item.strip())
                spot += 1
        else:
            for item in new_list:
                shopping_list.append(item.strip())

2 Answers

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,390 Points
Chris Freeman
Chris Freeman
Treehouse Moderator 68,390 Points

You have a typo in show_list()

def show_list():
    count = 1
    for itme in shopping_list:  # <--should be 'item' not 'itme'
        print("{}: {}".format(count, item))
        count += 1

Why does the code still work? Because item is defined in the global namespace. show_list is just using the last known value.