Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by Devesh Singh
Devesh Singh
5,267 Points

listItems = document.querySelectorAll("#rainbow"); This does not work, please help.

listItems = document.querySelectorAll("#rainbow");

This does not work, please help.

index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
js/app.js 
let listItems;
listItems = document.querySelectorAll("#rainbow");
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}

2 Answers

paulscanlon
PLUS
paulscanlon
Courses Plus Student 26,735 Points
paulscanlon
paulscanlon
Courses Plus Student 26,735 Points

Hey

Try grabbing the list items within #rainbow not just the list itself.

Happy coding

Paul

Steven Ang
Steven Ang
41,749 Points
Steven Ang
Steven Ang
41,749 Points

You are only targetting the ul element. You need to target all of the li inside the ul (#rainbow) tag. Then the loop will work.

let listItems = document.querySelectorAll("#rainbow li");