Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Data Structures Exploring the Java Collection Framework Sets

Gaspar Santiago
Gaspar Santiago
3,377 Points

Logic Error?

Expected 5 authors, but received 0

What am I missing?

com/example/BlogPost.java
package com.example;

import java.io.Serializable;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;


public class BlogPost implements Comparable<BlogPost>, Serializable {
  private String mAuthor;
  private String mTitle;
  private String mBody;
  private String mCategory;
  private Date mCreationDate;

  public BlogPost(String author, String title, String body, String category, Date creationDate) {
    mAuthor = author;
    mTitle = title;
    mBody = body;
    mCategory = category;
    mCreationDate = creationDate;
  }

  public int compareTo(BlogPost other) {
    if (equals(other)) {
      return 0;
    }
    return mCreationDate.compareTo(other.mCreationDate);
  }

  public String[] getWords() {
    return mBody.split("\\s+");
  }

  public List<String> getExternalLinks() {
    List<String> links = new ArrayList<String>();
    for (String word : getWords()) {
      if (word.startsWith("http")) {
        links.add(word);
      }
    }
    return links;
  }

  public String getAuthor() {
    return mAuthor;
  }

  public String getTitle() {
    return mTitle;
  }

  public String getBody() {
    return mBody;
  }

  public String getCategory() {
    return mCategory;
  }

  public Date getCreationDate() {
    return mCreationDate;
  }
}
com/example/Blog.java
package com.example;

import java.util.List;
import java.util.TreeSet;
import java.util.HashSet;
import java.util.Set;

public class Blog {
  List<BlogPost> mPosts;

  public Blog(List<BlogPost> posts) {
    mPosts = posts;
  }

  public List<BlogPost> getPosts() {
    return mPosts;
  }  

  public Set<String> getAllAuthors()//Create a method in the Blog class called getAllAuthors 
  {
    Set<String> allAuthors = new TreeSet<String>();//They should be sorted alphabetically. (TreeSet)
    for(BlogPost post : mPosts)//that loops over all the posts
    {
      post.getAuthor(); 
    }
    return allAuthors; //and returns a java.util.Set of all the authors, which are stored as Strings.
  }
}

1 Answer

andren
andren
28,558 Points

You create the set correctly, and return it correctly, but you never actually add any data to it. In your for loop you run post.getAuthor() which returns a string, but you don't actually do anything with that string, you just retrieve it and then throw it away.

Change the code inside of the for loop to one that calls the add method of the allAuthors set, with post.getAuthor() as the argument, that is all you need to do to fix your code.