Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects (Retired) Creating the MVP For Each Loop

Priyatham Kunarapu
Priyatham Kunarapu
1,350 Points
Posted by Priyatham Kunarapu
Priyatham Kunarapu
1,350 Points

Logic seems write , What's the mistake ?

I did everything in the question step by step, but the code is not passing the test case , have rechecked the code many times but it seems right, What's the mistake ?

ScrabblePlayer.java 
public class ScrabblePlayer {
  private String mHand;
  private int mCount=0;
  public ScrabblePlayer() {
    mHand = "";
  }

  public String getHand() {
   return mHand;
  }

  public void addTile(char tile) {
    // Adds the tile to the hand of the player
    mHand += tile;
    getTileCount(tile);
  }

  public boolean hasTile(char tile) {
   return mHand.indexOf(tile) > -1;
  }

  public int getTileCount(char tile){
    for(char letter : mHand.toCharArray()){
       if(tile == letter){
         mCount++;
       }
    }
    return mCount;
  }
}

1 Answer

Kourosh Raeen
Kourosh Raeen
23,733 Points
Kourosh Raeen
Kourosh Raeen
23,733 Points

At the top of the class declare mCount, but don't initialize it yet. Set mCount to zero inside the method since it needs t be zero each time the method is called:

public class ScrabblePlayer {
  private String mHand;
  private int mCount;

public ScrabblePlayer() {
    mHand = "";
  }

  public String getHand() {
   return mHand;
  }

  public void addTile(char tile) {
    // Adds the tile to the hand of the player
    mHand += tile;
    getTileCount(tile);
  }

  public boolean hasTile(char tile) {
   return mHand.indexOf(tile) > -1;
  }

  public int getTileCount(char tile){
    mCount=0
    for(char letter : mHand.toCharArray()){
       if(tile == letter){
         mCount++;
       }
    }
    return mCount;
  }
}

Actually, I see no reason why you need a member variable here, so I would just use a local variable:

public class ScrabblePlayer {
  private String mHand;

public ScrabblePlayer() {
    mHand = "";
  }

  public String getHand() {
   return mHand;
  }

  public void addTile(char tile) {
    // Adds the tile to the hand of the player
    mHand += tile;
    getTileCount(tile);
  }

  public boolean hasTile(char tile) {
   return mHand.indexOf(tile) > -1;
  }

  public int getTileCount(char tile){
    int count = 0;
    for(char letter : mHand.toCharArray()){
       if(tile == letter){
         count++;
       }
    }
    return count;
  }
}
Craig Dennis
Craig Dennis
Treehouse Teacher
Craig Dennis
Craig Dennis
Treehouse Teacher

Yep the member variable is messing you up...I run a couple of test cases through and it is incrementing each time. A local variable will work!