Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Java Java Objects (Retired) Creating the MVP For Each Loop

Priyatham Kunarapu
Priyatham Kunarapu
1,350 Points

Logic seems write , What's the mistake ?

I did everything in the question step by step, but the code is not passing the test case , have rechecked the code many times but it seems right, What's the mistake ?

ScrabblePlayer.java
public class ScrabblePlayer {
  private String mHand;
  private int mCount=0;
  public ScrabblePlayer() {
    mHand = "";
  }

  public String getHand() {
   return mHand;
  }

  public void addTile(char tile) {
    // Adds the tile to the hand of the player
    mHand += tile;
    getTileCount(tile);
  }

  public boolean hasTile(char tile) {
   return mHand.indexOf(tile) > -1;
  }

  public int getTileCount(char tile){
    for(char letter : mHand.toCharArray()){
       if(tile == letter){
         mCount++;
       }
    }
    return mCount;
  }
}

1 Answer

Kourosh Raeen
Kourosh Raeen
23,732 Points

At the top of the class declare mCount, but don't initialize it yet. Set mCount to zero inside the method since it needs t be zero each time the method is called:

public class ScrabblePlayer {
  private String mHand;
  private int mCount;

public ScrabblePlayer() {
    mHand = "";
  }

  public String getHand() {
   return mHand;
  }

  public void addTile(char tile) {
    // Adds the tile to the hand of the player
    mHand += tile;
    getTileCount(tile);
  }

  public boolean hasTile(char tile) {
   return mHand.indexOf(tile) > -1;
  }

  public int getTileCount(char tile){
    mCount=0
    for(char letter : mHand.toCharArray()){
       if(tile == letter){
         mCount++;
       }
    }
    return mCount;
  }
}

Actually, I see no reason why you need a member variable here, so I would just use a local variable:

public class ScrabblePlayer {
  private String mHand;

public ScrabblePlayer() {
    mHand = "";
  }

  public String getHand() {
   return mHand;
  }

  public void addTile(char tile) {
    // Adds the tile to the hand of the player
    mHand += tile;
    getTileCount(tile);
  }

  public boolean hasTile(char tile) {
   return mHand.indexOf(tile) > -1;
  }

  public int getTileCount(char tile){
    int count = 0;
    for(char letter : mHand.toCharArray()){
       if(tile == letter){
         count++;
       }
    }
    return count;
  }
}
Craig Dennis
Craig Dennis
Treehouse Teacher

Yep the member variable is messing you up...I run a couple of test cases through and it is incrementing each time. A local variable will work!