Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Python Build a Social Network with Flask Takin' Names Controlling sessions

Jay McCormick
Jay McCormick
6,646 Points

logout_user

Is there something I missed here? I thought this was pretty straightforward, but my code isn't passing.

lunch.py
from flask import Flask, g, render_template, flash, redirect, url_for
from flask.ext.bcrypt import check_password_hash
from flask.ext.login import LoginManager, login_user, current_user, login_required, logout_user

import forms
import models

app = Flask(__name__)
app.secret_key = 'this is our super secret key. do not share it with anyone!'
login_manager = LoginManager()
login_manager.init_app(app)
login_manager.login_view = 'login'


@login_manager.user_loader
def load_user(userid):
    try:
        return models.User.select().where(
            models.User.id == int(userid)
        ).get()
    except models.DoesNotExist:
        return None


@app.before_request
def before_request():
    g.db = models.DATABASE
    g.db.connect()
    g.user = current_user


@app.after_request
def after_request(response):
    g.db.close()
    return response


@app.route('/register', methods=('GET', 'POST'))
def register():
    form = forms.SignUpInForm()
    if form.validate_on_submit():
        models.User.new(
            email=form.email.data,
            password=form.password.data
        )
        flash("Thanks for registering!") 
    return render_template('register.html', form=form)


@app.route('/login', methods=('GET', 'POST'))
def login():
    form = forms.SignUpInForm()
    if form.validate_on_submit():
        try:
            user = models.User.get(
                models.User.email == form.email.data
            )
            if check_password_hash(user.password, form.password.data):
                login_user(user)
                flash("You're now logged in!")
            else:
                flash("No user with that email/password combo")
        except models.DoesNotExist:
              flash("No user with that email/password combo")
    return render_template('register.html', form=form)

@app.route('/logout')
def logout():
  logout_user()
  return redirect(url_for('/login'))


@app.route('/secret')
@login_required
def secret():
    return "I should only be visible to logged-in users"

1 Answer

Nathan Tallack
Nathan Tallack
22,159 Points

You were VERY close.

Take the leading / off your login url. Also it is a good idea to use the login_required decorator, just to be sure. ;)

Here is how your code would look with those changes.

@app.route('/logout')
@login_required
def logout():
  logout_user()
  return redirect(url_for('login'))
Jay McCormick
Jay McCormick
6,646 Points

oh man that was close, but still so far! why no '/' in the url_for redirect?

Nathan Tallack
Nathan Tallack
22,159 Points

The url_for will prefix the URL and then finish the prefix with a /. So you putting the / in there actually made it // which is why it was returning a 404. :)

Chris Freeman
Chris Freeman
Treehouse Moderator 68,064 Points

You don't include slashes because the flask url_for() function "accepts the name of the function as first argument and a number of keyword arguments, each corresponding to the variable part of the URL rule. Unknown variable parts are appended to the URL as query parameters." [See docs]

Nathan Tallack
Nathan Tallack
22,159 Points

Yeah, like Chris said. :)

Thanks Chris.