Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Fabiola Barrientos
Fabiola Barrientos
9,467 Points

Maximum call stack size exceeded

Im stuck on this code challenge. I dont really know what to do here. When I run it the error message: maximum call stack size exceeded appears. I would apreaciate it a lot if I got some help.

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
    set major(major){
        this._major = major;
        if(Student.level == "Senior" || Student.level == "Junior") {
            this.major = Student.level;
        } else {
            this.major = "none"; 
        }
    }
}

var student = new Student(3.9, 60);

1 Answer

jb30
jb30
44,805 Points
jb30
jb30
44,805 Points

Instead of using this.major in this.major = Student.level; and this.major = "none";, try using this._major. this.major without the _ calls the setter function.

You will also need to change Student.level to this.level and capitalize the n in "None". You could change this._major = Student.level; to this._major = major; or delete the line entirely, since it was previously set in the first line of the function.