method in class help!

Question

there must be something wrong in my programming below,though it pass the task.
if i delete the two attributes ''open=7","close=21" in def, then it will return a NameError: name 'open' is not defined.i don't know why it happens.
```method.py
class Store(): 
    open = 7
    close = 22
    a='we open from {} to {}'
    def hours(self):
        open = 7
        close = 22
        return self.a.format(open,close)
```

Jennifer Nordell · Accepted Answer

Hi there!  Yes, your code does pass, but that's because you've redefined the variables locally inside the method.  The better way to do this would be to format the string with the properties of the object.  And you were on the right track!  You used self.a as the string to format.  What we were looking for is to format the string with self.open and self.close.  So if you remove your open and close variables from the method we get something that should look like this:
```python
def hours(self):
    return self.a.format(self.open,self.close)
```
Hope this clarifies things! :sparkles:

Welcome to the Treehouse Community

Looking to learn something new?

chiu szu ting

chiu szu ting

method in class help!

1 Answer

Jennifer Nordell

Jennifer Nordell

chiu szu ting

chiu szu ting