Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Collections (2016, retired 2019) Dungeon Game Hit points

Ian Cole
Ian Cole
454 Points
Posted by Ian Cole
Ian Cole
454 Points

Movement Issues

Im getting no errors from this code when I run it by itself, so I'm pretty stumped with trying to figure this out. Does anyone else see where I'm going wrong here?

movement.py 
# EXAMPLES:
# move((1, 1, 10), (-1, 0)) => (0, 1, 10)
# move((0, 1, 10), (-1, 0)) => (0, 1, 5)
# move((0, 9, 5), (0, 1)) => (0, 9, 0)

def move(player, direction):

    x, y, hp = player
    if x == 0 or x < 0:
        x = 0
        hp -= 5
    if x == 9 or x > 9:
        x = 9
        hp -= 5
    if y == 0 or y < 0:
        y = 0
        hp -= 5
    if y == 9 or y > 9:
        y = 9
        hp -= 5

    player = x, y, hp
    return player

1 Answer

Steven Parker
Steven Parker
231,269 Points
Steven Parker
Steven Parker
231,269 Points

When you say "no errors" are you also testing that it produces the correct results?

Using the 3 examples shown in the comments, I get:

  • (1, 1, 10) instead of (0, 1, 10)
  • (0, 1, 5) (that one seems OK)
  • (0, 9, -5) instead of (0, 9, 0)

Here's a few hints:

  • you don't use "direction", but it's essential to knowing which way and how far to move
  • "hp" should only be reduced once even if more than one dimension is violated
  • if the movement would go out of bounds, the original position should be returned unchanged