Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Kevin Jones
Kevin Jones
1,324 Points

My code doesn't work

I have tried a few different ways of doing this but it won't work. Can anyone see what I am doing wrong?

script.js
function max(value1, value2) {
} if (value1 > value2) {
return value1;
 } else {
return value2;
 }
console.log( max(10,5) );

3 Answers

See comments:

function max(value1, value2) {
} if (value1 > value2) {  //move the closing bracket found here to the end of the function
return value1;
 } else {
return value2;
 }
console.log( max(10,5) ); //use alert
Richard Verbraak
Richard Verbraak
7,739 Points

I think you're missing a closing bracket hence the error saying your return value is outside of your function. Compare it to this one for example.

function max(value1, value2) {
  if(value1 > value2) {
    return value1;
  } else {
    return value2;
  }
}

console.log(max(15,10));
Kevin Jones
Kevin Jones
1,324 Points

How annoying! thanks guys. Spent 2 days on that!

Richard Verbraak
Richard Verbraak
7,739 Points

Embrace the frustration that comes (and is to come) with programming! Happens to all of us ;)