Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge

Gary Calhoun
Gary Calhoun
10,317 Points
Posted by Gary Calhoun
Gary Calhoun
10,317 Points

My code for this challenge

It seems to be working:)

var html = '';
var red;
var green;
var blue;
var rgbColor;


for (var i = 1; i <= 10; i += 1) {
  red = Math.floor(Math.random() * 256 );
  green = Math.floor(Math.random() * 256 );
  blue = Math.floor(Math.random() * 256 );
  rgbColor = 'rgb(' + red + ',' + green + ',' + blue + ')';
  html += '<div style="background-color:' + rgbColor + '"></div>';
}

document.write(html);

Here is it even tidier with a function being called for reusability

//generates random colors in a div
var html = '';
var red;
var green;
var blue;
var rgbColor;

function colors() {
  red = Math.floor(Math.random() * 256 );
  green = Math.floor(Math.random() * 256 );
  blue = Math.floor(Math.random() * 256 );
}

for (var i = 1; i <= 10; i += 1) {
  colors();
  rgbColor = 'rgb(' + red + ',' + green + ',' + blue + ')';
  html += '<div style="background-color:' + rgbColor + '"></div>';
}

document.write(html);
Chad Donohue
Chad Donohue
5,657 Points

What about

function getRandomColor() {
  return Math.floor(Math.random() * 256); 
}

function getRandomRGB() {
  return 'rgb(' + getRandomColor() + ',' + getRandomColor() + ',' + getRandomColor() + ')'; 
}

function generateColorCircle() {
  return '<div style="background-color:' + getRandomRGB() + ';"></div>'; 
}

for (var i = 0; i < 10; i+=1) {
  document.write(generateColorCircle());
}
Gary Calhoun
Gary Calhoun
10,317 Points
Gary Calhoun
Gary Calhoun
10,317 Points

Interesting will try it out with my code and see how it works, it does look a pretty clean though. Thanks!