Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Tracking Multiple Items with Arrays Using For Loops with Arrays

Tayyeba Shoaib
Tayyeba Shoaib
7,797 Points
Posted by Tayyeba Shoaib
Tayyeba Shoaib
7,797 Points

My code seems similar to the one shown in the video, but it isn't working. Please help.

Can someone tell me what's wrong with my code?

var playList = [
  'I Did It My Way',
  'Respect',
  'Imagine',
  'Born to Run',
  'Louie Louie',
  'Maybellene'
];

function print(message) {
  document.write(message);
}
function printList( list ) {
  var listHTML = "<ol>";
  for (var i = 0; i < list.length; i += 1) {
    listHTML += "<li>" + list[i] + "</li>";
    listHTML += "</ol>"
    print(listHTML);
  }
}
printList(playList);

1 Answer

Serhii Lihus
Serhii Lihus
6,352 Points

Hi there Tayyeba!

Problem was in function printList.

In for loop you were trying to close ordered list in each iteration and after this displaying it.

for (var i = 0; i < list.length; i += 1) {
    ...
    listHTML += "</ol>"
    print(listHTML);
    ...
}

All you need to do, is to move those two lines of code out of the for loop. And everthing will work as you expected ;)

Here is improved version.

function printList( list ) {
  var listHTML = "<ol>";
  for (var i = 0; i < list.length; i += 1) {
    listHTML += "<li>" + list[i] + "</li>";
  }
  listHTML += "</ol>"
  print(listHTML);
}

Best regards!

Tayyeba Shoaib
Tayyeba Shoaib
7,797 Points
Tayyeba Shoaib
Tayyeba Shoaib
7,797 Points

That worked. Thank you.