My code works but is it correct?

Question

I paused the video and created the script he described. it works perfectly but is it the correct way to write it? i see other people have something completely different. just want to know if this is acceptable

'''shopping list script'''

def myshoppingcart(on, things = []):


  while on >=1:

    print("Commands = [shop, DONE]")

    command = input("Enter a command: ")

    if command == "SHOP".lower():

      putitinthecart = input("Name of item? ")

      things.append(putitinthecart)
      print(things)
    elif command == "DONE".upper():
      on -=4
      print(things)
      print("Checking out your Items....\nThank you have a nice day!")
      on -=2
    else:
      print("INVALID COMMAND, PLEASE LOOK AT THE 'COMMANDS' ")

myshoppingcart(5)

Answer 1 · 2016-03-13T19:54:28Z

March 13, 2016 7:54pm

Your code does indeed work so well done on figuring it out before finishing the video! I'm a bit of a pragmatist so I'd say if it works, then it's acceptable.

One of the big lesson I've learned is to try to write as little code as possible (especially if code is going to be deployed on something with limited memory like embedded microcontrollers). One specific example is on your 'while' statement. Instead of making it based off the value of 'on,' you can change it to say "while True:". This will make the loop infinite until you choose to end it. This way you can get rid of the two lines that decrease the value of 'on' (i.e. "on -=4" and "on -=2") and simply put in "break" at the end of your 'elif' command. This also eliminates the need to pass in the 'on' variable into your 'myshoppingcart' function. In this example, the extra lines don't really add a lot but it's good practice to try to make applications as stripped down as possible. Does this make sense?

Keep up the good work!

Welcome to the Treehouse Community

Looking to learn something new?

adrian lineweaver

adrian lineweaver

My code works but is it correct?

1 Answer

Walker Bolger

Walker Bolger

adrian lineweaver

adrian lineweaver