Python Python Basics (2015) Letter Game App Letter Game Refinement

Jonathan Camacho
Jonathan Camacho
1,504 Points

My Letter Game does not print "You win!" or "You lose!" when the Strikes end or when the word is guessed. Please Help!

It does not break

Alex Moats
Alex Moats
4,530 Points

Can you add your code block?

Steven Parker
Steven Parker
177,891 Points

Please show your code, and be sure to use the instructions for code formatting in the Markdown Cheatsheet pop-up below the "Add an Answer" area. :arrow_heading_down: Or watch this video on code formatting.

Jonathan Camacho
Jonathan Camacho
1,504 Points
import random
import os
import sys

words = [
    'dog',
    'cat',
    'tiger',
    'wolf',
    'rhino',
    'eagle',
    'ladybug',
    'tucan',
    'alien',
    'dinosaur',
    'shark'
]

def clear():
    if os.name == 'nt':
        os.system('cls')
    else:
        os.system('clear')

def draw(bad_guesses, good_guesses, secret_word):
    clear()

    print('')
    print('Strikes: {}/7'.format(len(bad_guesses)))

    for letter in bad_guesses:
        print(letter, end=' ')
    print('\n\n')

    for letter in secret_word:
        if letter in good_guesses:
            print(letter, end='')
        else:
            print('_', end='')

    print('')


def get_guess(bad_guesses, good_guesses):
    while True:
        guess = input("Guess a letter: ").lower()

        if len(guess) != 1:
            print("One letter at a time, please :)")
        elif guess in bad_guesses or guess in good_guesses:
            print("You've already guessed that one :l")
        elif not guess.isalpha():
            print("Only letters, please :]")    
        else:
            return guess


def play(done):
    clear()
    secret_word = random.choice(words)
    bad_guesses = []
    good_guesses = []

    while True:
        draw(bad_guesses, good_guesses, secret_word)
        guess = get_guess(bad_guesses, good_guesses)

        if guess in secret_word:
            good_guesses.append(guess)
            found = True
            for letter in secret_word:
                if letter not in good_guesses:
                    found = False
            if found:
                print("You win!")
                print("The secret word was {}".format(secret_word))
                done = True
        else:
            bad_guesses.append(guess)
            if len(bad_guesses) == 7:
                draw(bad_guesses, good_guesses, secret_word)
                print("You lost!")
                print("The secret word was {}".format(secret_word))
                done = True

    if done:
        play_again = input("Play again? Y/n ").lower()
        if play_again != 'n':
            return play(done=False)
        else:
            sys.exit()

def welcome():
    start = input("Press enter/return to start or Q to quit ").lower()
    if start == 'q':
        print("See ya!")
        sys.exit()
    else:
        return True

print('Welcome to Letter Guess!')

done = False

while True:
    clear()
    welcome()
    play(done)

:arrow_heading_up:

1 Answer

Brian Boring
PRO
Brian Boring
Pro Student 3,904 Points

Your "if done:" qualifier needs to be indented in order to be included in your "while True" loop.