Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Treehouse Club - MASH MASH - JavaScript Stuff You Can Change

Humsini Gopal
Humsini Gopal
2,201 Points

My MASH page is not working...Only reloads when I press "submit."

I have tried to fix the JavaScript code, but I have no idea where I've gone wrong. Does anyone have an idea what's wrong?

HTML page:

<!DOCTYPE html>
  <meta charset="utf-8">

  <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=0.5, maximum-scale=0.5, minimal-ui">

  <title>Futuristic MASH</title>
  <link href="normalize.css" rel="stylesheet">
  <link href="style.css" rel="stylesheet">

  <h1 class="logo"><img src="img/mash-logo.svg" /></h1>
  <p class="description">Fill in the blanks and your future will be foretold.</p>

<form action="" method="post" id="mash">

  <div id="answers" class="hide">
      <p>You will live in <span id="location"></span> and love to be at <span id="hangout"></span> as you are a <span id="profession"></span> who owns a <span id="home"></span>.

  <div class="bucket">

    <div class="choice-bucket">
      <h4 class="highlight">What city will you live in?</h4>
        <input name="location[]" type="text">
        <input name="location[]" type="text">
        <input name="location[]" type="text">
        <input name="location[]" type="text">

      <div class="choice-bucket">
        <h4 class="highlight">Your future profession?</h4>
          <input name="profession[]" type="text">
          <input name="profession[]" type="text">
          <input name="profession[]" type="text">
          <input name="profession[]" type="text">

     <div class="choice-bucket">
        <h4 class="highlight">Your favorite hangout?</h4>
          <input name="hangout[]" type="text">
          <input name="hangout[]" type="text">
          <input name="hangout[]" type="text">
          <input name="hangout[]" type="text">


  <input type="submit" value="Tell my fortune">
<script src="script.js"></script>

JavaScript page:

function random_number(num) {  // New function called random_choice that takes one parameter, num (or a number)
// Get a random number between 0 and a passed-in number
var num = num || 4;  // If no number passed in, default to 4
return Math.floor(Math.random() * num); // Round the answer down (floor) of a random number between 0 and 1 and multiply it by a number. Then return a value and exit the function.

function mash_choice() {  // New function called mash_choice that doesn't take any parameters 
// Since MASH is a special case, give it its own list
var mash = ['mansion', 'apartment', 'shack', 'house'];  // The array of choices to pick from 
var randomNum = random_number(4);  // Use the above function to get a number between 0 and 4
return mash[randomNum];  // Return the list item the random number function just picked and exit the function 

function get_answer(category) { 
// Get a random answer from the available answers in a given category
var choices = [];  // A blank array to hold the user provided answer  
var selector = 'input[name="' + category + []'"]';  // Build a CSS selector for the blanks in our passed in category 
var inputs = document.querySelectorAll(selector);  // Get all of the inputs that match our selector 
var answer;  

for (var i = 0; i < inputs.length; i++) {  // Begin a for loop that will run through the code. i++ = add one to the counter which is "i"
    answer = inputs[i].value;  // Get the input with the index value of the counter and get the value ie. if they typed in dog, you get back "dog" 
    if (answer !== '') {  // If answer doesn't equal a blank... !== means doesn't equal 
        choices.push(answer); //...add it to the end of the list 
return choices[random_number(choices.length)];   // Pick and return a random choice choice.length = number of answers the user provided in that category 

function fill_in_answers(answers) {
// Find the spans that need filled
var home = document.querySelector('#home');  // This says make a new variable and find the HTML tag that has the ID of "home" 
var profession = document.querySelector('#profession');
var pet = document.querySelector('#pet');
var location = document.querySelector('#location');

// Fill them with the provided answers
home.innerText = answers['mash'];
profession.innerText = answers['profession'];
pet.innerText = answers['pet'];
location.innerText = answers['location'];
home.innerHTML = answers.mash;  // Change the content of the element in the HTML doc with the id "home" to the "mash" value in answers 
profession.innerHTML = answers.profession;  // Change the content of the element in the HTML doc with the id "career" to the "career" value in answers 
pet.innerHTML = answers.pet;
location.innerHTML = answers.location;

 function handle_submission(evt) {
evt.preventDefault();  // Stop the form from reloading the page 
evt.stopPropagation();  // Stop the form from reloading the page

// Build up our answers object
var answers = {
    'mash': mash_choice(),
    'profession': get_answer('profession'),
    'pet': get_answer('pet'),
    'location': get_answer('location')
// Fill in the answers

var answer_div = document.querySelector('#answers');

// Find the form on the page and attach a handler for when it's submitted
var form = { document.querySelector('#mash');  
form.addEventListener('submit', handle_submission);  // Anytime the form is submitted, we want to call the function handle_submission

Hi Humsini Gopal, just letting you know that I wrapped your code in code blocks to make it easier to read.

Michael Sawyer
Michael Sawyer
2,086 Points

Hi Humsini, I'm new to this and I could very easily be incorrect, but I believe in JavaScript where ever you have profession, pet, and location all need to be changed to location, hangout, and profession in the order you have them in HTML. If I'm wrong someone please correct it for me, thanks