Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge, Part 2

Jose Perez Lopez
Jose Perez Lopez
9,304 Points
Posted by Jose Perez Lopez
Jose Perez Lopez
9,304 Points

My program does not run if I print the content, in this case print(html); outside of the for loop.

When I put my function to printout the divs onto the page, my program does not run, however, when I put it inside the for loop, it runs just fine.

var html = ' '; var rgbColor = ''; function getRandomColor(){ return Math.floor(Math.random() * 256); } function color(){ return rgbColor += 'rgb(' + getRandomColor() + ',' + getRandomColor() + ',' + getRandomColor() + ')'; } function printDoc(message){ document.write(message); } for(var i = 0; i < 300; i++){ html += '<div style="background-color:' + color() + '"></div>'; html = ''; rgbColor = ''; } printDoc(html); <<<------ OUTSIDE THE FOR LOOP

This does not run

var html = ' '; var rgbColor = ''; function getRandomColor(){ return Math.floor(Math.random() * 256); } function color(){ return rgbColor += 'rgb(' + getRandomColor() + ',' + getRandomColor() + ',' + getRandomColor() + ')'; } function printDoc(message){ document.write(message); } for(var i = 0; i < 300; i++){ html += '<div style="background-color:' + color() + '"></div>'; printDoc(html); <<------ INSIDE THE FOR LOOP html = ''; rgbColor = ''; } But this does

1 Answer

KRIS NIKOLAISEN
KRIS NIKOLAISEN
54,972 Points
KRIS NIKOLAISEN
KRIS NIKOLAISEN
54,972 Points

You should try console.log(html) just before printDoc(html) to show what you are trying to write. Anyways I modified your color() function to not concatenate rgbColor, and removed html = '' from your loop and it appears to function correctly:

var html = '';

function getRandomColor(){ 
    return Math.floor(Math.random() * 256);
                         }
function color(){
    return 'rgb(' + getRandomColor() + ',' + getRandomColor() + ',' + getRandomColor() + ')';
                }

function printDoc(message){
    document.write(message);
}

for(var i = 0; i < 300; i++){
    html += '<div style="background-color:' + color() + '"></div>'; 
    }

console.log(html)
printDoc(html)