Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Posted by shyarkhalil
.a{fill-rule:evenodd;}techdegree seal-36
shyarkhalil
Front End Web Development Techdegree Graduate 17,762 Points

My refactoring solution

Hi everyone! This is my refactoring solution for The Refactor Challenge. Could you please have a look and give my some feedback? Thanks!

var html = ''; var red; var green; var blue; var rgbColor;

function colorRange () { return randomRgbColor = Math.floor(Math.random() * 256 ); }

for (i = 1; i < 11; i++) { red = colorRange (); green = colorRange (); blue = colorRange (); rgbColor = 'rgb(' + red + ',' + green + ',' + blue + ')'; html += '<div style="background-color:' + rgbColor + '"></div>'; }

document.write(html);

Tri Pham
Tri Pham
18,671 Points

You should probably link to the challenge. But it seems pretty good to me. Personally, I'd probably create another function that creates a rgbColor string (maybe called getRandomColor, I'm not that great at creating name) so that it'll look like

for (var i = 1; i < 11; i++) { rgbColor = getRandomColor(); html += '<div style="background-color:' + rgbColor + '"></div>'; }