Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Riley Hays
Riley Hays
6,204 Points
Posted by Riley Hays
Riley Hays
6,204 Points

My setter method isn't returning the correct value. How should I access the level property to set the major?

I thought that my if statement would correctly access the level property and then use that information to set this._major. However something is going wrong and I'm not sure what it is.

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
  get major(){
  return this._major;
  }
  set major(major){

    if(this.level === ('Senior' || 'Junior')){
       this._major = major;
    } else {
      this._major = 'None';
    }

  }

}

var student = new Student(3.9, 60);

1 Answer

Steven Parker
Steven Parker
229,785 Points
Steven Parker
Steven Parker
229,785 Points

You have the right idea, but when you combine comparisons using logic operators, each side must be a complete expression:

    if (this.level === 'Senior' || this.level === 'Junior') {

Also, this challenge only asks for a setter method, you don't need to create a getter method.