My solution being too simple ?

Question

I just used a forEach loop and did it the lazy way with writing multiple document.write functions but it did the trick. Is this considered bad practice or lazy?

My code:

for (var prop in students) {
  document.write("<h2>Student: " + students[prop].name + "</h2>");
  document.write("<p>Track: " + students[prop].track + "</p>")
  document.write("<p>Achievements: " + students[prop].achievements + "</p>")
  document.write("<p>Points: " + students[prop].points + "</p>")
}

Answer 1 · 2019-03-05T15:00:17Z

March 5, 2019 3:00pm

If it works it works! It depends on the scope of the project you are working on. If you have a project with a rigid structure and you only need a function for a very specific task, workarounds like this will do fine.

For some more complex projects with lots of moving parts, keeping your code modular and easy to swap values and variables is key. Good job thinking outside the box though!

Dylan

Answer 2 · 2019-03-05T20:52:24Z

March 5, 2019 8:52pm

If you're resorting to self-described laziness, then you aren't learning.

And no, this wouldn't fly in a work environment. Code this verbose looks amateur; especially since you're doing pointless work by iterating over the students collection, getting a prop, and then using that prop to access what you want in the students collection. One of the usages of javascript objects (and maps in general) is to avoid the need for iterators by using a dictionary style lookup. (Sometimes we have to iterate over maps to turn them into other collections, but that's a different topic).

Welcome to the Treehouse Community

Looking to learn something new?

Richard Verbraak

Richard Verbraak

My solution being too simple ?

2 Answers

Dylan Glover

Dylan Glover

Lukas Dahlberg

Lukas Dahlberg