Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Posted by shyarkhalil
.a{fill-rule:evenodd;}techdegree seal-36
shyarkhalil
Front End Web Development Techdegree Graduate 17,762 Points

My solution for Rooms

https://w.trhou.se/0tqmk14v4k

Joel Bardsley
Joel Bardsley
31,258 Points
Joel Bardsley
Joel Bardsley
31,258 Points

Nice work. I hope you don't mind me chiming in, but one thing you could do to make your for loop more efficient:

for(var i=0; i<employeesRooms.length; i +=1) {
  if(employeesRooms[i].available === true) {
    var li = document.createElement("li");
    ul.appendChild(li);
    li.classList.add("empty");
    li.innerHTML = employeesRooms[i].room;
  } else {
    var li = document.createElement("li");
    ul.appendChild(li);
    li.classList.add("full");
    li.innerHTML = employeesRooms[i].room;
  }
}

Instead of repeating the code that creates the li element and appends it to the ul, you can keep that outside of the if statement, and just use the if statement to apply the class you need for an empty or full room. Something like this:

for(var i=0; i<employeesRooms.length; i +=1) {
  var li = document.createElement("li");
  ul.appendChild(li);
  li.innerHTML = employeesRooms[i].room;

  if(employeesRooms[i].available === true) {
    li.classList.add("empty");
  } else {
    li.classList.add("full");
  }
}

Hope that makes sense!

1 Answer