Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops Working with 'for' Loops The Refactor Challenge – Duplicate Code

Brian Cumalander
Brian Cumalander
2,725 Points

My solution for the Refactor Challenge

Got it down to 8 lines of code excluding spaces

let html = '';
let randomRGB;
let randomValue = () => Math.floor(Math.random() * 256);

for(i=0; i<=10; i++){
  randomRGB = `rgb( ${randomValue()}, ${randomValue()}, ${randomValue()} )`;
  html += `<div style="background-color: ${randomRGB}">${i}</div>`;
}

document.querySelector('main').innerHTML = html;

1 Answer

Steven Parker
Steven Parker
229,644 Points

Good job! :+1:
And if you convert randomRGB into a function, you can initialize it when you declare it, and save another line:

let html = '';
let randomRGB = () => `rgb(${randomValue()}, ${randomValue()}, ${randomValue()})`;
let randomValue = () => Math.floor(Math.random() * 256);

for (i = 0; i <= 10; i++) {
  html += `<div style="background-color: ${randomRGB()}">${i}</div>`;
}

document.querySelector('main').innerHTML = html;