Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript Loops Working with 'for' Loops The Refactor Challenge – Duplicate Code

Brian Cumalander
Brian Cumalander
2,354 Points
Posted by Brian Cumalander
Brian Cumalander
2,354 Points

My solution for the Refactor Challenge

Got it down to 8 lines of code excluding spaces

let html = '';
let randomRGB;
let randomValue = () => Math.floor(Math.random() * 256);

for(i=0; i<=10; i++){
  randomRGB = `rgb( ${randomValue()}, ${randomValue()}, ${randomValue()} )`;
  html += `<div style="background-color: ${randomRGB}">${i}</div>`;
}

document.querySelector('main').innerHTML = html;

1 Answer

Steven Parker
Steven Parker
221,323 Points
Steven Parker
Steven Parker
221,323 Points

Good job! :+1:
And if you convert randomRGB into a function, you can initialize it when you declare it, and save another line:

let html = '';
let randomRGB = () => `rgb(${randomValue()}, ${randomValue()}, ${randomValue()})`;
let randomValue = () => Math.floor(Math.random() * 256);

for (i = 0; i <= 10; i++) {
  html += `<div style="background-color: ${randomRGB()}">${i}</div>`;
}

document.querySelector('main').innerHTML = html;