My solution, thoughts?

Question

So, as the title says, this is my solution, and curious about your thoughts and perhaps some suggestions to improve it.

The biggest issue I have right now with this code is that #moveRight() and #moveLeft() are very similar and I would like to have them in one function.

The main reason for my refactoring was to clean up the Game.js file a bit and not have too many if statements in there and just make the code a bit more readable in general. Another change I made was, that when the player reaches the end of the board, either left or right, and continues moving against the boundary they move over to the other side of the board, making the game a bit more fluent.

Game.js

 handleKeyDown(e){
        if(this.ready){
            let activeToken = this.activePlayer.activeToken
            activeToken.move(e.key, this.board.columns)
        }
    }

Token.js

 move (key, columns){
    switch(key) {
     case 'ArrowLeft':
       this.#moveLeft(columns)
        break
      case 'ArrowRight':
        this.#moveRight(columns)
        break
      }
    }

Token.js (Private functions, only accssible inside Token.js)

#moveLeft(numOfColumns){
    if(this.columnLocation === 0){
      this.htmlToken.style.left = (numOfColumns-1) * 76
      this.columnLocation = numOfColumns - 1 
    }else {
      this.htmlToken.style.left = this.offsetLeft - 76
      this.columnLocation -= 1
    }
  }

  #moveRight(numColumns){
    if(this.columnLocation === numColumns-1){
      this.htmlToken.style.left = 0
      this.columnLocation = 0
    }else {
      this.htmlToken.style.left = this.offsetLeft + 76
      this.columnLocation += 1
    }
  }

Answer 1 · 2022-07-14T15:16:06Z

July 14, 2022 3:16pm

You could combine #moveRight() and #moveLeft() into a single function by adding an additional parameter to indicate direction. But I'm not sure this would make the code more compact or enhance readability.

Also note that it's a "best practice" to terminate statements with semicolons and consistently using this will in itself enhance readability.

Welcome to the Treehouse Community

Looking to learn something new?

Armend Azemi

Armend Azemi

My solution, thoughts?

1 Answer

Steven Parker

Steven Parker

Armend Azemi

Armend Azemi