Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Django Basics Test Time Test our Writer model

Omprakash Panigrahi
Omprakash Panigrahi
9,632 Points
Posted by Omprakash Panigrahi
Omprakash Panigrahi
9,632 Points

My test didnt pass.

This is my first time writing a test in python. I dont know what I am doing wrong. Any help is appreciated.

articles/tests.py 
from django.test import TestCase
from .models import Writer


class WriterModelTestCase(TestCase):
    '''Tests for the Writer model'''
    def writer_creation(self):
        writer = Writer.objects.create(
            name='test',
            email='something@gmail.com',
            bio='this is the something bio of something'
        )
        self.assertIn(Writer.mailto, email)
articles/models.py 
from django.db import models


class Article(models.Model):
    headline = models.CharField(max_length=255)
    publish_date = models.DateTimeField()
    content = models.TextField()
    writer = models.ForeignKey('Writer')

    def __str__(self):
        return self.headline


class Writer(models.Model):
    name = models.CharField(max_length=255)
    email = models.EmailField()
    bio = models.TextField()

    def __str__(self):
        return self.name

    def mailto(self):
        return '{} <{}>'.format(self.name, self.email)

2 Answers

Nicholas Ward
Nicholas Ward
5,797 Points
Nicholas Ward
Nicholas Ward
5,797 Points

Your code is super close, just a couple small changes and it should pass.

  1. This is really tough to catch if the Django Basics course is your first introduction to testing, but test names all need to start with "test" i.e. test_writer_creation.

  2. The naming scheme can make this tough to see sometimes, but you are checking that the writer instance of the Writer model was correctly created (so use lowercase writer in your assertion).

  3. mailto is a method of the Writer model, so you need to call it with .mailto() instead of .mailto.

  4. email is an attribute of writer, so you want to use writer.email instead of just email.

  5. self.assertIn(a , b) checks that a is contained in b, so you want to swap the order so that you're checking that writer.email is contained in the output of writer.mailto().

class WriterModelTestCase(TestCase):
    '''Tests for the Writer model'''
    def test_writer_creation(self):
        writer = Writer.objects.create(
            name='test',
            email='something@gmail.com',
            bio='this is the something bio of something'
        )
        self.assertIn(writer.email, writer.mailto())
Omprakash Panigrahi
Omprakash Panigrahi
9,632 Points
Omprakash Panigrahi
Omprakash Panigrahi
9,632 Points

Thanks a lot! I got it working after following your detailed instructions.