Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

David Morisset
David Morisset
13,323 Points
Posted by David Morisset
David Morisset
13,323 Points

Need feedback for a jquery plugin

Hello,

After spending a while trying to learn javascript and JQuery with the treehouse videos (which are really good, thanks to Dave and Andrew and all the others ! ), i decided to push my own code on github.

So, here is a JQuery plugin that does simple things (adds extra file input markup to html, links a preview, checks total size limit, number of files...) : https://github.com/David-44/multibrowse The good news is that it works ! Well, except on IE8 and 9 (and it's untested on IE10 and 11 for the moment...) so if you need something like that for your website, go for it.

Since it's my first ever plugin, there are of course millions of things that i'm unsure of and a lot of questions. So, if anyone has any feedback on the following topics, it would be great :

  • Is there something that looks bad or is considered bad practice in the code organisation or the code itself ?
  • Is the documentation ok ?
  • Any idea of functionalities that could make it better ?

Thanks in advance

1 Answer

Pedro Ferrari
Pedro Ferrari
14,295 Points
Pedro Ferrari
Pedro Ferrari
14,295 Points

Hello David Morisset , Just a small tip, if you really want to support it in IE8, you better use Jquery 1.x since 2.x does not support IE8. It might have broken IE9 too if you ask me :)

Here is a link: https://jquery.com/browser-support/ Cheers

David Morisset
David Morisset
13,323 Points
David Morisset
David Morisset
13,323 Points

Hi Pedro,

Thanks a lot for the tip. I think i won't bother much with IE8 and IE9 support for this plugin though, it's using the file API which doesn't work on old versions of IE anyway ;)

Cheers