Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Java Java Objects Delivering the MVP Applying a Discount Code

Need help with my code. Wondering why it doesn't throw IllegalArgumentException

Pretty sure that my code should work but somehow it doesn't. Need help if anyone can point out if there's something wrong with my code. Thank you.

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    try{      
      this.discountCode = normalizeDiscountCode(discountCode);
    }catch(IllegalArgumentException iae){
      System.out.println(iae.getMessage());
    }
  }

  private String normalizeDiscountCode(String discountCode){
    boolean accepatable = false;
    for( char c : discountCode.toCharArray()){
      if(Character.isLetter(c) || c == '$') {
        accepatable = true;
      }
      else{
        accepatable = false;
        break;
      }
    }

    if(accepatable){
      return discountCode.toUpperCase();
    }else{
      throw new IllegalArgumentException("Invalid discount code");
    }     
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Steven Parker
Steven Parker
218,596 Points

The instructions don't ask you to add a "try/catch", and by catching the exception yourself it prevents the validator from detecting it.

Thank you for pointing it out. Still trying to familiarize with the syntax.