Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Giovanni Dalla Rizza
Giovanni Dalla Rizza
10,637 Points
Posted by Giovanni Dalla Rizza
Giovanni Dalla Rizza
10,637 Points

Node.js | code challange Implementation error

Can't find the issue in my code

index.js 
var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
utilities.js 
function merge(content, values) {
  for (var key in values) {
     content = content.replace("&" + key + "&", values.key);
  }
  return content;
};


module.exports.merge = merge;

1 Answer

Joe Beltramo
Joe Beltramo
Courses Plus Student 22,191 Points

1) In your utilities file, you are checking for "&" not "%" on either side. Therefore replace results in not finding anything to replace. Change it to read:

content = content.replace("%" + key + "%", values.key);

2) Referencing values.key will result in undefined. Instead of dot notation, use bracket notation: values[key]

content = content.replace("%" + key + "%", values[key]);

Bracket notation is a safer choice when variable names contain any special characters of a name assigned as a variable. Had there been a direct call to the member first_name, dot notation would suffice.

Hope that helps