Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Data Structures Exploring the Java Collection Framework Maps

Matt Adams
Matt Adams
4,856 Points

Non-Static Method Error, For-Each Not Applicable Error, and Reached End of File Error, need help!

Here is my code in Blog.java:

public Map<String, Integer> getCategoryCounts() { Map<String, Integer> categoryCounts = new HashMap<String, Integer>(); for (BlogPost post : Blog.getPosts()) { for (String category : post.getCategory()) { Integer count = categoryCounts.get(category); if (count == null) { count = 0; } count++; categoryCounts.put(category, count); } } return categoryCounts;

When I run the code, I get the following three errors:

./com/example/Blog.java:41: error: reached end of file while parsing } ^ ./com/example/Blog.java:30: error: non-static method getPosts() cannot be referenced from a static context for (BlogPost post : Blog.getPosts()) { ^ ./com/example/Blog.java:31: error: for-each not applicable to expression type for (String category : post.getCategory()) { ^ required: array or java.lang.Iterable found: String

Does anyone have any advice?

Thanks in advance!

com/example/BlogPost.java
package com.example;

import java.io.Serializable;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;


public class BlogPost implements Comparable<BlogPost>, Serializable {
  private String mAuthor;
  private String mTitle;
  private String mBody;
  private String mCategory;
  private Date mCreationDate;

  public BlogPost(String author, String title, String body, String category, Date creationDate) {
    mAuthor = author;
    mTitle = title;
    mBody = body;
    mCategory = category;
    mCreationDate = creationDate;
  }

  public int compareTo(BlogPost other) {
    if (equals(other)) {
      return 0;
    }
    return mCreationDate.compareTo(other.mCreationDate);
  }

  public String[] getWords() {
    return mBody.split("\\s+");
  }

  public List<String> getExternalLinks() {
    List<String> links = new ArrayList<String>();
    for (String word : getWords()) {
      if (word.startsWith("http")) {
        links.add(word);
      }
    }
    return links;
  }

  public String getAuthor() {
    return mAuthor;
  }

  public String getTitle() {
    return mTitle;
  }

  public String getBody() {
    return mBody;
  }

  public String getCategory() {
    return mCategory;
  }

  public Date getCreationDate() {
    return mCreationDate;
  }
}
com/example/Blog.java
package com.example;

import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.TreeSet;

public class Blog {
  List<BlogPost> mPosts;

  public Blog(List<BlogPost> posts) {
    mPosts = posts;
  }

  public List<BlogPost> getPosts() {
    return mPosts;
  }

  public Set<String> getAllAuthors() {
    Set<String> authors = new TreeSet<>();
    for (BlogPost post: mPosts) {
      authors.add(post.getAuthor());
    }
    return authors;
  }

  public Map<String, Integer> getCategoryCounts() {
    Map<String, Integer> categoryCounts = new HashMap<String, Integer>();
    for (BlogPost post : Blog.getPosts()) {
        for (String category : post.getCategory()) {
            Integer count = categoryCounts.get(category);
            if (count == null) {
                count = 0;
            }
            count++;
            categoryCounts.put(category, count);
        }
    }
    return categoryCounts;
  }

1 Answer

Kourosh Raeen
Kourosh Raeen
23,733 Points

The problem is that you're calling the getPosts() method on the Blog class itself, but to be able to do this getPosts() must be a static method. You actually, don't need to use any method there because all the posts are already in the member variable mPosts. So change:

for (BlogPost post : Blog.getPosts())

to

for (BlogPost post : mPosts)

This will take care of one of the errors. I let you try to resolve the other one but ask me if you get stuck.

Matt Adams
Matt Adams
4,856 Points

Thanks Kourosh. Not sure why I missed that.

I was able to work through the other two errors, now I'm simply returning unexpected data. Progress!

Thanks for your help.

  • Matt