Not conforming to protocol 'APIClient'

It's easy to miss, but at 3:23 in the video Pasan says "We got rid of the init method in the protocol...", so although that particular step is missing, I believe that's what the lesson intends for us to do.

Additionally, in Swift 3, closure parameters need to be explicitly defined as '@escaping', which in turn means we need to update the protocol accordingly so the extension implementation matches the protocol, otherwise, we don't have a default implementation and the ForecastAPIClient class does not conform to the protocol.

protocol APIClient {
    var configuration: URLSessionConfiguration { get }
    var session: URLSession { get }

//    init(config: URLSessionConfiguration)

    func JSONTaskWithRequest(request: URLRequest, completion: @escaping JSONTaskCompletion) -> JSONTask
    func fetch<T>(request: URLRequest, parse: @escaping (JSON) -> T?, completion: @escaping (APIResult<T>) -> Void)
}

Thanks Harish, that solved it for me. I'm still curious why Pasan didn't get the same error we did though.

Harish, adding arbitrary additions like this on to the protocol breaks all the work we have done so far. What if in the future one wants to create a class that conforms to that protocol but does not require a key for its implementation.

The error that we get is probably due to the changes to Swift that were introduced with recent updates.

As for me, I have decided to remove the initializer from the protocol. I don't see any purpose in having it sit in there.

It's because the implementation in the ForecastClient doesn't match the signature of the protocol for the init method in APIClient. So in order to correct that you either have to match the implementation to the protocol or match the protocol to the implementation. I've decided to add the parameter "APIKey: String" to the protocol since that seems like what Pasan intended but probably missed in a previous lesson.

protocol APIClient { var configuration: NSURLSessionConfiguration { get } var session: NSURLSession { get }

init(config: NSURLSessionConfiguration, APIKey: String)

func JSONTaskWithRequest(request: NSURLRequest, completion: JSONTaskCompletion) -> JSONTask
func fetch<T>(request: NSURLRequest, parse: JSON -> T?, completion: APIResult<T> -> Void)

}

Hello guys, I'm experiencing the same issue. I know that this has previously been brought up, but is there a correct way of doing this? Please bare in mind that I am now using Swift 3.0

         import Foundation

         final class ForecastAPIClient : APIClient {

         let configuration: URLSessionConfiguration
         lazy var session: URLSession = {
         return URLSession(configuration: self.configuration)
         }()

         private let token: String

        init(config: URLSessionConfiguration, APIKey: String) {
        self.configuration = config
        self.token = APIKey
        }

       convenience init(APIKey: String) {
       self.init(config: URLSessionConfiguration.default, APIKey: APIKey)
       }
       }

Thanks Bien Pham, I am aware of this, however everything I try doesn't seem to work. What part of the APIClient Protocol should I conform to within the ForecastClient.Swift?

Here's some of my code within the APIClient:

     protocol APIClient {
     var configuration: URLSessionConfiguration { get }
     var session: URLSession { get }

     init(config: URLSessionConfiguration)

     func JSONTaskWithRequest(request: URLRequest, completion: JSONTaskCompletion) -> JSONTask
     func fetch<T>(request: URLRequest, parse: (JSON) -> T?, completion: (APIResult<T>) -> Void)
  }

   extension APIClient {
   func JSONTaskWithRequest(request: URLRequest, completion: @escaping JSONTaskCompletion) -> JSONTask {

(continued)

Bien Pham, thank you for your help, but unfortunately I am still lost.

Dont do that guys!, just add the default init method also for the protocol so you will have:

    init(config: NSURLSessionConfiguration, APIKey: String) {
        self.configuration = config
        self.token = APIKey
    }
    init(config: NSURLSessionConfiguration) {
        self.configuration = config
        self.token = ""
    }
    convenience init(APIKey: String) {
        self.init(config: NSURLSessionConfiguration.defaultSessionConfiguration(), APIKey: APIKey)
    }

Remember that you can have the same method with different parameters. Also i thought about changing the APIClient protocol to this:

protocol APIClient {
    var session: NSURLSession { get }
    var configuration: NSURLSessionConfiguration { get }

    init(config: NSURLSessionConfiguration, APIKey: String)
    func JSONTaskWithRequest(request: NSURLRequest, completionHandler: JSONTaskCompletion) -> JSONTask
    func fetch<T>(request: NSURLRequest, parse: JSON -> T?, completion: APIResult<T> -> Void)
}

so the ForecastAPIClient would have only two initializers:

    init(config: NSURLSessionConfiguration, APIKey: String) {
        self.configuration = config
        self.token = APIKey
    }
    convenience init(APIKey: String) {
        self.init(config: NSURLSessionConfiguration.defaultSessionConfiguration(), APIKey: APIKey)
    }