not printing? been an hour of trialing and changing things..........

Question

here's my code:

var upper = 10000;
var randomNumber = getRandomNumber(upper);
var guess; var attempts = 0;

function getRandomNumber(upper) {
    return Math.floor(Math.random() * upper) + 1;
}

while(guess !== randomNumber) {
    guess = getRandomNumber(upper);
    attempts += 1;
}

document.write("<p>The random number was " + randomNumber() + "<p>");
document.write("<p>The computer guessed " + attempts()+ "to get it right</p>");

please elaborate

Answer 1 · 2016-07-10T22:49:41Z

July 10, 2016 10:49pm

Hi Ben,

Debalina is correct - in your document.write statements, you need to append the variables randomNumber and attempts, so no parentheses. Also, your second paragraph needs an extra word and space. Here's a codepen with the solution. You can see your code in action. I've also pasted it below:

var upper = 10000;
var randomNumber = getRandomNumber(upper);
var guess; var attempts = 0;

function getRandomNumber(upper) {
    return Math.floor(Math.random() * upper) + 1;
}

while(guess !== randomNumber) {
    guess = getRandomNumber(upper);
    attempts += 1;
}

document.write("<p>The random number was " + randomNumber + "<p>");
document.write("<p>The computer guessed " + attempts+ " times to get it right</p>");

Answer 2 · 2016-07-10T23:28:00Z

July 10, 2016 11:28pm

Hi Ben,

In addition to the other answers describing your syntax errors, here's an alternative implementation of what you're trying to do that might prove more insightful. Let me know if you have any questions.

// get a random number between two numbers
// prompt user to guess the number within a certain number of tries
// if the guessed number is the right number, tell user they won
// if the guessed number is less than the right number, tell user to guess higher
// if the guessed number is greater than the right number, tell user to guess lower

var minimumNumber = 1,
    maximumNumber = 100,
    randomNumber = Math.floor(Math.random() * (maximumNumber - minimumNumber + 1)) + minimumNumber,
    guessCount = 0,
    maxGuesses = 10

while (maxGuesses > 0) {
    var guessedNumber = parseInt(prompt('Guess a number between ' + minimumNumber + ' and ' + maximumNumber + '!'))

    if (guessedNumber === randomNumber) {
        alert('You win! The number was ' + randomNumber + '. It took you ' + guessCount + ' guesses.')
        break;
    } else if (guessedNumber < randomNumber) {
        alert('Nope. Higher...')
    } else {
        alert('Nope. Lower...')
    }

    if (maxGuesses === 0) {
        alert('You lose! The random number was ' + randomNumber + '. It took you ' + guessCount + ' guesses.')
    }

    maxGuesses--
    guessCount++
}

Answer 3 · 2016-07-10T21:08:23Z

July 10, 2016 9:08pm

Please try randomNumber instead of randomNumber() and attempts instead of attempts() in document.write()

Welcome to the Treehouse Community

Looking to learn something new?

Ben Mohammad

Ben Mohammad

not printing? been an hour of trialing and changing things..........

3 Answers

Greg Kaleka

Greg Kaleka

miikis

miikis

Debalina Mukherjee

Debalina Mukherjee