Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
Jeremy Smalley
8,529 PointsNot sure if I am doing this one correct. ERROR: You didn't pass in an anonymous function in to the `each` method call.
On line 9 of app.js, use the method we used to cycle over each of the menu links. Pass in an anonymous function too.
is the Challenge Task.
//Problem: It look gross in smaller browser widths and small devices
//Solution: To hide the text links and swap them out with a more appropriate navigation
//Create a select and append to #menu
var $select = $("<select></select>");
$("#menu").append($select);
//Cycle over menu links
$("#menu a").each( function () {});
var $anchor = $(this);
var $option = $("<option></option>");
$option.val($anchor.attr("href"));
$option.text($anchor.text());
$select.append($option);
});
//Create an option
//option's value is the href
//option's text is the text of link
//append option to select
//Create button
//Bind click to button
//Go to select's location
//Modify CSS to hide links on small width and show button and select
//Also hides select and button on larger width and show's links
//Deal with selected options depending on current page
<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
</head>
<body>
<div id="menu">
<ul>
<li class="selected"><a href="index.html">Home</a></li>
<li><a href="about.html">About</a></li>
<li><a href="contact.html">Contact</a></li>
<li><a href="support.html">Support</a></li>
<li><a href="faqs.html">FAQs</a></li>
<li><a href="events.html">Events</a></li>
</ul>
</div>
<h1>Home</h1>
<p>This is the home page.</p>
<script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
<script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>
3 Answers
Damien Watson
27,419 PointsHi Jeremy, looks like you accidentally closed your function call. You need to remove the '})' in the 'each(function() {' line:
//Cycle over menu links
$("#menu a").each( function () { //});
var $anchor = $(this);
var $option = $("<option></option>");
$option.val($anchor.attr("href"));
$option.text($anchor.text());
$select.append($option);
});
Merritt Lawrenson
13,477 PointsYou have a closing '});' set that ends your function both at the start and the end. You need to get rid of one so you end up with:
$("#menu a").each(function () {
// code here
});
If things don't work, one of the first things to do is look at your opening and closing braces, tags, brackets, parentheses, etc, and make sure everything matches up and nothing is missing either its opener or closer. It's a super easy way for things to stop working right.
Jeremy Smalley
8,529 PointsThanks,