Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial


not sure what I am missing here

I don't know why my code not passing

class Letter:
    def __init__(self, pattern=None):
        self.pattern = pattern
    def __str__(self):
        output = "" #empty string to add items inside
        for letter in self.pattern: # looping through each letter in the pattern attribute
            if letter == ".": # checking if letter is "."
                output.append("dot") # If check is true, add it to the empty list
            elif letter == "_": # checking if lettet is "_"
                output.append("dash") # check is true, add it to the empty list
            return  "_".join("output")  # join the two results to come up with the desired output     

class S(Letter):
    def __init__(self):
        pattern = ['.', '.', '.']

1 Answer

Greg Kaleka
Greg Kaleka
39,021 Points

Hey Matthew,

Three issues with your code:

  1. You have the right idea starting with an empty output, but your join method use gives away that ouput shouldn't start out as a string - it should be a list. Then we can join it together into a string and return it.
  2. Your return line is joining the literal string "output", not the variable output. You also need to join with hyphens, not underscores, per the instructions.
  3. Your return line is inside the loop. Watch your indentation!

Let me know if that makes sense!

Cheers :beers:


Thanks Greg, makes perfect sense