Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Posted by bristel
bristel
1,252 Points

Not sure why code doesn't work.

function max(x,y) { if (x > y) return x; } else { return y; };

max(4,6);

script.js 
function max(x,y) {
  if (x > y)
    return x;
} else {
    return y;
};

max(4,6);

5 Answers

Nicholas Hebb
Nicholas Hebb
18,872 Points

The curly braces should be more like this:

function max(x,y) {
  if (x > y) {
    return x;
  } else { 
    return y; 
  }
}

You can also shorten this using a ternary operator [1]:

function max(x, y) {
  return x > y ? x : y;
}

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Conditional_Operator

Nicholas Hebb
Nicholas Hebb
18,872 Points
Nicholas Hebb
Nicholas Hebb
18,872 Points

Hint: Look at your curly braces.

Also, the semicolon after the function declaration is unneeded.

bristel
bristel
1,252 Points
bristel
bristel
1,252 Points

Hi Nicholas, thanks for the quick reply. I like the hints better than just the answer! I made the curly brace change and removed semi colon after the function declaration. Still having some trouble. This is what i have now.

function max(x,y) if (x > y) { return x; } else { return y; };

max(4,6)

bristel
bristel
1,252 Points
bristel
bristel
1,252 Points

its in the correct format though. :)

bristel
bristel
1,252 Points
bristel
bristel
1,252 Points

Awesome, thank you! I should have known that! We haven't learned ternary operators yet but I'll research it! :)